Page MenuHomePhabricator
Differential D14622

Remove addExtraQuicksandConfig
ClosedPublic
Actions

Authored by chad on Dec 1 2015, 6:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 7:00 PM
Unknown Object (File)
Fri, Dec 13, 4:19 AM
Unknown Object (File)
Fri, Dec 13, 1:15 AM
Unknown Object (File)
Sun, Dec 1, 7:26 AM
Unknown Object (File)
Sun, Dec 1, 7:26 AM
Unknown Object (File)
Sun, Dec 1, 7:26 AM
Unknown Object (File)
Thu, Nov 28, 7:47 PM
Unknown Object (File)
Thu, Nov 28, 11:42 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9690: Remove calls to methods deprecated by newPage()
Commits
Restricted Diffusion Commit
rPbbd1da4f8d78: Remove addExtraQuicksandConfig
Summary

Removes all calls to addExtraQuicksandConfig Ref T9690

Test Plan

grep for addExtraQuicksandConfig, view a Pholio Page with and without chatbar, edit a pholio mock, save mock.

Diff Detail

Repository
rP Phabricator
Branch
addExtraQuicksandConfig
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9184
Build 10859: Run Core Tests
Build 10858: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35374.Dec 1 2015, 6:04 PM
chad retitled this revision from to Remove addExtraQuicksandConfig.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9690: Remove calls to methods deprecated by newPage().
Herald added a subscriber: Korvin. · View Herald TranscriptDec 1 2015, 6:04 PM
epriestley accepted this revision.Dec 1 2015, 6:16 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 1 2015, 6:16 PM
Closed by commit rPbbd1da4f8d78: Remove addExtraQuicksandConfig (authored by chad, committed by chad). · Explain WhyDec 1 2015, 6:29 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T9881: Call to undefined method PhabricatorProjectBoardViewController::addExtraQuickSandConfig().Dec 1 2015, 9:32 PM

Revision Contents
Changeset List

PathSize
src/
applications/
base/
controller/
19 lines
pholio/
controller/
5 lines
4 lines

Diff 35374

View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/pholio/controller/PholioMockEditController.php

Loading...
View Options

src/applications/pholio/controller/PholioMockViewController.php

Loading...
Phabricator · Built by Phacility