Paths

Table of Contentst

Differential D14604

Add a linter rule for invalid octals
ClosedPublic
Actions

Authored by joshuaspence on Nov 30 2015, 11:35 AM.

Tags

None

Referenced Files

	F14918338: D14604.id35346.diff
	Thu, Feb 13, 8:47 PM

	Unknown Object (File)
	Sun, Feb 9, 3:19 AM

	Unknown Object (File)
	Mon, Feb 3, 3:21 AM

	Unknown Object (File)
	Sun, Feb 2, 2:37 AM

	Unknown Object (File)
	Fri, Jan 31, 9:52 AM

	Unknown Object (File)
	Wed, Jan 29, 9:12 PM

	Unknown Object (File)
	Wed, Jan 29, 9:12 PM

	Unknown Object (File)
	Wed, Jan 29, 9:12 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC560e4ae4919b: Add a linter rule for invalid octals

Summary

PHP doesn't handle octals very well. Basically, it seems that any numeric scalar matching /^0\d+$/ will be treated as an octal, whereas this should be /^0[0-7]+$/. As a result, 08 and 09 are both treated as 0 (because they are invalid octals. This diff adds a linter rule to detect this abnormality.

Test Plan

Added unit tests.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/lint/linter/xhpast/rules/ArcanistInvalidOctalNumericScalarXHPASTLinterRule.php:23	XHP105	Function Call Should Be Type Cast

Unit

Test Failures

Build Status

Buildable 9156
Build 10811: Run Core Tests
Build 10810: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	55 ms	ArcanistCurlyBraceArrayIndexXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	15 ms	ArcanistCurlyBraceArrayIndexXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	572 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	175 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	24 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (3 Failed · 292 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35324.Nov 30 2015, 11:35 AM

joshuaspence retitled this revision from to Add a linter rule for invalid numerals.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 30 2015, 11:35 AM

Herald added a subscriber: epriestley. · View Herald Transcript

With tests

epriestley accepted this revision.Nov 30 2015, 7:35 PM

epriestley added a reviewer: epriestley.

epriestley added inline comments.

src/lint/linter/xhpast/rules/__tests__/invalid-octal-numeric-scalar/octal.lint-test
3–4	Maybe include these test cases? 0 0.9 0xFf 0XFf 0b01 -08

This revision is now accepted and ready to land.Nov 30 2015, 7:35 PM

Moar tests

Herald added a subscriber: Korvin. · View Herald TranscriptDec 2 2015, 9:24 PM

joshuaspence retitled this revision from Add a linter rule for invalid numerals to Add a linter rule for invalid octals.Dec 2 2015, 9:25 PM

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence marked an inline comment as done.

joshuaspence removed a subscriber: Korvin.

Closed by commit rARC560e4ae4919b: Add a linter rule for invalid octals (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 9:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

lint/

linter/

xhpast/

rules/

ArcanistInvalidOctalNumericScalarXHPASTLinterRule.php

44 lines

__tests__/

ArcanistInvalidOctalNumericScalarXHPASTLinterRuleTestCase.php

11 lines

invalid-octal-numeric-scalar/

octal.lint-test

5 lines

Diff 35346

src/__phutil_library_map__.php

Loading...

src/lint/linter/xhpast/rules/ArcanistInvalidOctalNumericScalarXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/tests/ArcanistInvalidOctalNumericScalarXHPASTLinterRuleTestCase.php

Loading...

src/lint/linter/xhpast/rules/tests/invalid-octal-numeric-scalar/octal.lint-test

Loading...

test.php

Loading...