Page MenuHomePhabricator
Differential D14595

Modernize Pholio
ClosedPublic
Actions

Authored by chad on Nov 29 2015, 12:37 AM.
Tags
None
Referenced Files
F19758685: D14595.diff
Tue, Feb 17, 9:19 PM
F19747599: D14595.id35305.diff
Sun, Feb 15, 6:29 PM
F19044382: D14595.id35305.diff
Nov 27 2025, 2:38 AM
F19030075: D14595.id35329.diff
Nov 24 2025, 8:08 PM
F18952762: D14595.diff
Nov 12 2025, 6:29 AM
F18930370: D14595.diff
Nov 10 2025, 1:46 AM
F18877328: D14595.id.diff
Nov 6 2025, 7:30 AM
F18858225: D14595.diff
Nov 1 2025, 9:11 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9690: Remove calls to methods deprecated by newPage()
Commits
Restricted Diffusion Commit
rP5686fb7fa415: Modernize Pholio
Summary

Use modern methods in Pholio

Test Plan

View list, create mock, edit mock, view mobile menu

Diff Detail

Repository
rP Phabricator
Branch
newpage-pholio
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9116
Build 10747: Run Core Tests
Build 10746: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35305.Nov 29 2015, 12:37 AM
chad retitled this revision from to Modernize Pholio.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 29 2015, 12:37 AM
chad added a task: T9690: Remove calls to methods deprecated by newPage().Nov 29 2015, 1:09 AM
epriestley accepted this revision.Nov 29 2015, 4:45 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2015, 4:45 PM
Closed by commit rP5686fb7fa415: Modernize Pholio (authored by chad, committed by chad). · Explain WhyNov 30 2015, 2:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
pholio/
controller/
24 lines
11 lines
11 lines
25 lines

Diff 35305

View Options

src/applications/pholio/controller/PholioController.php

Loading...
View Options

src/applications/pholio/controller/PholioMockEditController.php

Loading...
View Options

src/applications/pholio/controller/PholioMockListController.php

Loading...
View Options

src/applications/pholio/controller/PholioMockViewController.php

Loading...
Phabricator · Built by Phacility