Page MenuHomePhabricator
Differential D14593

Modernize Countdown
ClosedPublic
Actions

Authored by chad on Nov 28 2015, 11:40 PM.
Tags
None
Referenced Files
F15415183: D14593.id.diff
Thu, Mar 20, 4:41 AM
F15341509: D14593.id35330.diff
Sun, Mar 9, 8:41 PM
Unknown Object (File)
Feb 8 2025, 11:54 PM
Unknown Object (File)
Feb 8 2025, 11:54 PM
Unknown Object (File)
Feb 8 2025, 11:54 PM
Unknown Object (File)
Feb 8 2025, 11:54 PM
Unknown Object (File)
Feb 5 2025, 11:34 PM
Unknown Object (File)
Feb 5 2025, 11:16 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9690: Remove calls to methods deprecated by newPage()
Commits
Restricted Diffusion Commit
rPee102c7aca72: Modernize Countdown
Summary

Update to new modern methods.

Test Plan

View List, New Countdown, Edit Countdown, Delete Countdown

Diff Detail

Repository
rP Phabricator
Branch
newpage-countdown
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9114
Build 10743: Run Core Tests
Build 10742: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35302.Nov 28 2015, 11:40 PM
chad retitled this revision from to Modernize Countdown.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 28 2015, 11:40 PM
chad added a task: T9690: Remove calls to methods deprecated by newPage().Nov 28 2015, 11:40 PM
chad updated this revision to Diff 35303.Nov 28 2015, 11:42 PM
  • update
epriestley accepted this revision.Nov 29 2015, 4:44 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2015, 4:44 PM
Closed by commit rPee102c7aca72: Modernize Countdown (authored by chad, committed by chad). · Explain WhyNov 30 2015, 3:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35303

View Options

src/applications/countdown/controller/PhabricatorCountdownController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownEditController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownListController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownViewController.php

Loading...
Phabricator · Built by Phacility