Page MenuHomePhabricator
Differential D14593

Modernize Countdown
ClosedPublic
Actions

Authored by chad on Nov 28 2015, 11:40 PM.
Tags
None
Referenced Files
F14101151: D14593.id35303.diff
Tue, Nov 26, 3:50 PM
F14101017: D14593.id35302.diff
Tue, Nov 26, 3:43 PM
Unknown Object (File)
Mon, Nov 25, 1:53 AM
Unknown Object (File)
Sat, Nov 23, 2:16 PM
Unknown Object (File)
Sat, Nov 23, 1:45 PM
Unknown Object (File)
Thu, Nov 21, 1:50 PM
Unknown Object (File)
Sun, Nov 17, 1:17 AM
Unknown Object (File)
Fri, Nov 8, 10:55 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9690: Remove calls to methods deprecated by newPage()
Commits
Restricted Diffusion Commit
rPee102c7aca72: Modernize Countdown
Summary

Update to new modern methods.

Test Plan

View List, New Countdown, Edit Countdown, Delete Countdown

Diff Detail

Repository
rP Phabricator
Branch
newpage-countdown
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9113
Build 10741: Run Core Tests
Build 10740: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35302.Nov 28 2015, 11:40 PM
chad retitled this revision from to Modernize Countdown.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 28 2015, 11:40 PM
chad added a task: T9690: Remove calls to methods deprecated by newPage().Nov 28 2015, 11:40 PM
chad updated this revision to Diff 35303.Nov 28 2015, 11:42 PM
  • update
epriestley accepted this revision.Nov 29 2015, 4:44 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2015, 4:44 PM
Closed by commit rPee102c7aca72: Modernize Countdown (authored by chad, committed by chad). · Explain WhyNov 30 2015, 3:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35302

View Options

src/applications/countdown/controller/PhabricatorCountdownController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownEditController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownListController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownViewController.php

Loading...
Phabricator · Built by Phacility