Page MenuHomePhabricator

Implement PhabricatorDestructibleInterface in Phame
ClosedPublic

Authored by chad on Nov 28 2015, 7:12 PM.
Tags
None
Referenced Files
F15584680: D14586.id35290.diff
Thu, May 8, 5:22 AM
F15584313: D14586.id.diff
Thu, May 8, 2:50 AM
F15537691: D14586.id35287.diff
Thu, Apr 24, 3:07 PM
F15491999: D14586.id35287.diff
Sat, Apr 12, 9:41 AM
F15490593: D14586.id35290.diff
Fri, Apr 11, 6:40 PM
F15488951: D14586.id35289.diff
Fri, Apr 11, 4:35 AM
F15486065: D14586.id.diff
Thu, Apr 10, 4:40 AM
F15483876: D14586.diff
Wed, Apr 9, 3:04 PM
Subscribers

Details

Summary

Allows Blogs and Posts to be destroyed. Fixes T9756

Test Plan

Test bin/remove destroy POST and bin/remove destroy BLOG to great success.

Diff Detail

Repository
rP Phabricator
Branch
phame-destruct
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9099
Build 10720: Run Core Tests
Build 10719: arc lint + arc unit

Event Timeline

chad retitled this revision from to Implement PhabricatorDestructibleInterface in Phame.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Build failure looks like a missing arc liberate. Couple o' inlines.

src/applications/phame/storage/PhameBlog.php
331–332

You don't need this, $this is the same as $blog.

src/applications/phame/storage/PhamePost.php
262–263

You can get rid of this, it's unused and $this->delete() always does the same thing anyway.

This revision is now accepted and ready to land.Nov 28 2015, 8:00 PM
chad marked 2 inline comments as done.
chad edited edge metadata.
  • Updates
This revision was automatically updated to reflect the committed changes.