Implement PhabricatorDestructibleInterface in Phame
ClosedPublic
Actions

Authored by chad on Nov 28 2015, 7:12 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T9756: Allow Blogs and Posts to be archived

Commits

Summary

Allows Blogs and Posts to be destroyed. Fixes T9756

Test Plan

Test bin/remove destroy POST and bin/remove destroy BLOG to great success.

Repository

rP Phabricator

Branch

phame-destruct

Lint

Lint Passed

Unit

No Test Coverage

Build Status

	Time	Test
	540 ms	PhabricatorLibraryTestCase::Unknown Unit Message ("")
	0 ms	AlmanacNamesTestCase::Unknown Unit Message ("")
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("")
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("")
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 290 Passed)

chad retitled this revision from to Implement PhabricatorDestructibleInterface in Phame.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad edited the test plan for this revision. (Show Details)Nov 28 2015, 7:13 PM

Build failure looks like a missing arc liberate. Couple o' inlines.

src/applications/phame/storage/PhameBlog.php
331–332	You don't need this, `$this` is the same as `$blog`.
src/applications/phame/storage/PhamePost.php
262–263	You can get rid of this, it's unused and `$this->delete()` always does the same thing anyway.