Page MenuHomePhabricator
Differential D14571

Fix handling of implicit comment transaction in paste creation
ClosedPublic
Actions

Authored by epriestley on Nov 25 2015, 4:24 PM.
Tags
None
Referenced Files
F13108077: D14571.diff
Sun, Apr 28, 12:17 AM
Unknown Object (File)
Thu, Apr 25, 3:00 AM
Unknown Object (File)
Sat, Apr 13, 10:31 PM
Unknown Object (File)
Fri, Apr 12, 7:24 AM
Unknown Object (File)
Thu, Apr 11, 10:32 AM
Unknown Object (File)
Fri, Apr 5, 3:54 AM
Unknown Object (File)
Mar 7 2024, 4:44 AM
Unknown Object (File)
Mar 7 2024, 4:43 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9850: Creating a new paste fails with unhandled exception
Commits
Restricted Diffusion Commit
rPb21928599960: Fix handling of implicit comment transaction in paste creation
Summary

Fixes T9850. The getComment() test should be a hasComment() test, in order to discard empty comments.

Also backport a couple of future fixes which can get you into trouble if you reconfigure forms in awkward ways.

Test Plan

Created a new paste without a comment.

Diff Detail

Repository
rP Phabricator
Branch
pastecontent
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9061
Build 10664: Run Core Tests
Build 10663: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35252.Nov 25 2015, 4:24 PM
epriestley retitled this revision from to Fix handling of implicit comment transaction in paste creation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9850: Creating a new paste fails with unhandled exception.
chad accepted this revision.Nov 25 2015, 4:24 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 25 2015, 4:24 PM
Closed by commit rPb21928599960: Fix handling of implicit comment transaction in paste creation (authored by epriestley, committed by epriestley). · Explain WhyNov 25 2015, 4:25 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T9857: Column 'content' cannot be null.Nov 26 2015, 12:39 AM

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editfield/
16 lines
editor/
2 lines

Diff 35252

View Options

src/applications/transactions/editfield/PhabricatorEditField.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility