Paths

Table of Contentst

Differential D14538

Make rendered table of contents private in Phriction
ClosedPublic
Actions

Authored by epriestley on Nov 22 2015, 9:17 PM.

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rP449556ed8309: Make rendered table of contents private in Phriction

Summary

Oops, I missed this -- when properties are protected, Lisk assumes they database properties which should be stored and read from the database. To make Lisk ignore a property, make it private.

Test Plan

Should fix this:

Screen Shot 2015-11-22 at 1.15.56 PM.png (877×1 px, 108 KB)

Diff Detail

Repository

rP Phabricator

Branch

phrictioncontents

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8977
Build 10540: Run Core Tests
Build 10539: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35166.Nov 22 2015, 9:17 PM

epriestley retitled this revision from to Make rendered table of contents private in Phriction.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Repro for error is to edit a Phriction page.

chad accepted this revision.Nov 22 2015, 9:17 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 22 2015, 9:17 PM

Closed by commit rP449556ed8309: Make rendered table of contents private in Phriction (authored by epriestley, committed by epriestley). · Explain WhyNov 22 2015, 9:17 PM

This revision was automatically updated to reflect the committed changes.

oh haha, I guess I didn't re-test saving a document.

thx u :3

np :3

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

storage/

PhrictionContent.php

3 lines

Diff 35166

View Options

src/applications/phriction/storage/PhrictionContent.php

Make rendered table of contents private in PhrictionClosedPublicActions