Paths

Table of Contentst

Make rendered table of contents private in Phriction
ClosedPublic
Actions

Authored by epriestley on Nov 22 2015, 9:17 PM.

Tags

None

Referenced Files

	F14054739: D14538.diff
	Sat, Nov 16, 4:30 AM

	F14043730: D14538.diff
	Tue, Nov 12, 12:29 PM

	F14029483: D14538.id35167.diff
	Fri, Nov 8, 8:44 PM

	F14029481: D14538.id35166.diff
	Fri, Nov 8, 8:44 PM

	F14029479: D14538.id.diff
	Fri, Nov 8, 8:44 PM

	F14029170: D14538.diff
	Fri, Nov 8, 7:56 PM

	F14026108: D14538.diff
	Thu, Nov 7, 11:42 PM

	F13992582: D14538.id.diff
	Tue, Oct 22, 5:33 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rP449556ed8309: Make rendered table of contents private in Phriction

Summary

Oops, I missed this -- when properties are protected, Lisk assumes they database properties which should be stored and read from the database. To make Lisk ignore a property, make it private.

Test Plan

Should fix this:

Screen Shot 2015-11-22 at 1.15.56 PM.png (877×1 px, 108 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35166.Nov 22 2015, 9:17 PM

epriestley retitled this revision from to Make rendered table of contents private in Phriction.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Repro for error is to edit a Phriction page.

chad accepted this revision.Nov 22 2015, 9:17 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 22 2015, 9:17 PM

Closed by commit rP449556ed8309: Make rendered table of contents private in Phriction (authored by epriestley, committed by epriestley). · Explain WhyNov 22 2015, 9:17 PM

This revision was automatically updated to reflect the committed changes.

oh haha, I guess I didn't re-test saving a document.

thx u :3

np :3

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

storage/

PhrictionContent.php

3 lines

Diff 35167

View Options

src/applications/phriction/storage/PhrictionContent.php

Make rendered table of contents private in PhrictionClosedPublicActions