Differential D14513

Add a linter rule for nested namespaces
ClosedPublic
Actions

Authored by joshuaspence on Nov 18 2015, 10:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 10:02 PM

	Unknown Object (File)
	Mon, Nov 18, 1:02 AM

	Unknown Object (File)
	Thu, Nov 14, 8:54 AM

	Unknown Object (File)
	Mon, Nov 11, 6:14 AM

	Unknown Object (File)
	Sun, Nov 10, 11:42 AM

	Unknown Object (File)
	Fri, Nov 8, 8:42 PM

	Unknown Object (File)
	Fri, Nov 8, 8:42 PM

	Unknown Object (File)
	Fri, Nov 8, 7:55 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC149e7895fbd5: Add a linter rule for nested namespaces

Summary

Namespace declarations cannot be nested, see https://3v4l.org/kRUNj.

Test Plan

Added unit tests

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 8920
Build 10456: Run Core Tests
Build 10455: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	153 ms	ArcanistCppcheckLinterTestCase::Unknown Unit Message ("")
	456 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	10 ms	ArcanistRubyLinterTestCase::Unknown Unit Message ("")
	18 ms	ArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	14 ms	ArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (3 Failed · 264 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35110.Nov 18 2015, 10:29 PM

joshuaspence retitled this revision from to Add a linter rule for nested namespaces.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 18 2015, 10:29 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 18 2015, 10:38 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 18 2015, 10:38 PM

Closed by commit rARC149e7895fbd5: Add a linter rule for nested namespaces (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 19 2015, 8:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

lint/

linter/

xhpast/

rules/

ArcanistNestedNamespacesXHPASTLinterRule.php

29 lines

__tests__/

ArcanistNestedNamespacesXHPASTLinterRuleTestCase.php

10 lines

nested-namespaces/

nested.lint-test

9 lines

Diff 35110

src/__phutil_library_map__.php

Loading...

src/lint/linter/xhpast/rules/ArcanistNestedNamespacesXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/tests/ArcanistNestedNamespacesXHPASTLinterRuleTestCase.php

Loading...

src/lint/linter/xhpast/rules/tests/nested-namespaces/nested.lint-test

Loading...