Page MenuHomePhabricator

Extract PHIDs from transactions later, fixing Paste extraction/attachment
ClosedPublic

Authored by epriestley on Nov 16 2015, 6:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 3:52 AM
Unknown Object (File)
Feb 8 2025, 11:49 PM
Unknown Object (File)
Feb 8 2025, 11:49 PM
Unknown Object (File)
Feb 8 2025, 11:49 PM
Unknown Object (File)
Jan 30 2025, 4:50 AM
Unknown Object (File)
Jan 28 2025, 12:21 AM
Unknown Object (File)
Jan 27 2025, 11:28 PM
Unknown Object (File)
Jan 27 2025, 4:37 PM
Subscribers
None

Details

Summary

Fixes T9787. Currently, file PHID extraction logic happens very early, before we normalize/merge/etc the transactions.

In D14390, I changed how the CONTENT transaction works: before, callers would pass in a file PHID. Afterward, they just pass in the content.

Passing in the content is generaly easier and feels more correct, but inadvertenly broke PHID extraction because converting the content into a file PHID now happened after we extracted the PHID. So we'd extract the entire text of the paste as a "file PHID", which wouldn't work.

Instead, extract file PHIDs later. This impacts a couple of other applications (Conpherence, Pholio) which receive an object or have an unusual file-oriented transaction.

Test Plan
  • Made a new paste, verified the raw file attached to it properly.
  • Made and updated a mock, verified all the files attached properly.
  • Updated a Conpherence room image, verified the files attached properly.

Diff Detail

Repository
rP Phabricator
Branch
eengine15
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8875
Build 10383: Run Core Tests
Build 10382: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Extract PHIDs from transactions later, fixing Paste extraction/attachment.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2015, 5:17 AM
This revision was automatically updated to reflect the committed changes.