Page MenuHomePhabricator

Have EditEngine API methods provide the correct application to Conduit
ClosedPublic

Authored by epriestley on Nov 16 2015, 5:30 PM.
Tags
None
Referenced Files
F14063487: D14492.diff
Mon, Nov 18, 6:45 PM
F14018427: D14492.id35062.diff
Tue, Nov 5, 11:37 AM
F13995877: D14492.id.diff
Wed, Oct 23, 4:21 PM
F13978016: D14492.diff
Oct 18 2024, 9:08 PM
F13962898: D14492.diff
Oct 15 2024, 12:50 PM
Unknown Object (File)
Sep 12 2024, 1:37 AM
Unknown Object (File)
Sep 9 2024, 3:36 AM
Unknown Object (File)
Sep 6 2024, 7:11 PM
Subscribers

Details

Summary

Fixes T9799. Currently, if you can't see an application like Paste, we fatal when trying to generate a result for conduit.query, because the new EditEngine-based paste.edit method doesn't "know" that it's a "Paste" method.

Straighten this out, and use policies and queries a little more correctly/consistently.

Test Plan
  • Called conduit.query as a user who does not have permission to use Paste.
  • Before change: fatal.
  • After change: results, excluding "paste.*" methods.

Diff Detail

Repository
rP Phabricator
Branch
eengine13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8872
Build 10378: Run Core Tests
Build 10377: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Have EditEngine API methods provide the correct application to Conduit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2015, 5:49 PM
This revision was automatically updated to reflect the committed changes.