Page MenuHomePhabricator

Have EditEngine API methods provide the correct application to Conduit
ClosedPublic

Authored by epriestley on Nov 16 2015, 5:30 PM.
Tags
None
Referenced Files
F18976488: D14492.id35062.diff
Sun, Nov 16, 2:32 PM
F18785467: D14492.id35062.diff
Oct 14 2025, 4:14 AM
F18755989: D14492.diff
Oct 5 2025, 8:32 AM
F18600552: D14492.diff
Sep 13 2025, 10:00 AM
F18593448: D14492.diff
Sep 12 2025, 2:57 PM
F18052452: D14492.id35062.diff
Aug 4 2025, 2:35 AM
F18049818: D14492.id35062.diff
Aug 3 2025, 5:24 PM
F18021346: D14492.id35064.diff
Aug 2 2025, 8:09 PM
Subscribers

Details

Summary

Fixes T9799. Currently, if you can't see an application like Paste, we fatal when trying to generate a result for conduit.query, because the new EditEngine-based paste.edit method doesn't "know" that it's a "Paste" method.

Straighten this out, and use policies and queries a little more correctly/consistently.

Test Plan
  • Called conduit.query as a user who does not have permission to use Paste.
  • Before change: fatal.
  • After change: results, excluding "paste.*" methods.

Diff Detail

Repository
rP Phabricator
Branch
eengine13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8872
Build 10378: Run Core Tests
Build 10377: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Have EditEngine API methods provide the correct application to Conduit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2015, 5:49 PM
This revision was automatically updated to reflect the committed changes.