Page MenuHomePhabricator
Differential D14492

Have EditEngine API methods provide the correct application to Conduit
ClosedPublic
Actions

Authored by epriestley on Nov 16 2015, 5:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 6:22 PM
Unknown Object (File)
Fri, Dec 13, 6:22 PM
Unknown Object (File)
Fri, Dec 13, 6:22 PM
Unknown Object (File)
Sun, Dec 8, 9:37 AM
Unknown Object (File)
Wed, Dec 4, 1:16 AM
Unknown Object (File)
Wed, Nov 27, 11:24 AM
Unknown Object (File)
Nov 19 2024, 7:30 PM
Unknown Object (File)
Nov 18 2024, 6:45 PM
View All Files
Subscribers
cburroughs

Details

Reviewers
chad
Maniphest Tasks
T9799: nonsensical conduit.query auth errors/busted on this install
Commits
Restricted Diffusion Commit
rP12dd9ec3ff34: Have EditEngine API methods provide the correct application to Conduit
Summary

Fixes T9799. Currently, if you can't see an application like Paste, we fatal when trying to generate a result for conduit.query, because the new EditEngine-based paste.edit method doesn't "know" that it's a "Paste" method.

Straighten this out, and use policies and queries a little more correctly/consistently.

Test Plan
  • Called conduit.query as a user who does not have permission to use Paste.
  • Before change: fatal.
  • After change: results, excluding "paste.*" methods.

Diff Detail

Repository
rP Phabricator
Branch
eengine13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8872
Build 10378: Run Core Tests
Build 10377: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35062.Nov 16 2015, 5:30 PM
epriestley retitled this revision from to Have EditEngine API methods provide the correct application to Conduit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9799: nonsensical conduit.query auth errors/busted on this install.
cburroughs added a subscriber: cburroughs.Nov 16 2015, 5:42 PM
chad accepted this revision.Nov 16 2015, 5:49 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2015, 5:49 PM
Closed by commit rP12dd9ec3ff34: Have EditEngine API methods provide the correct application to Conduit (authored by epriestley, committed by epriestley). · Explain WhyNov 16 2015, 6:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35062

View Options

src/applications/conduit/method/ConduitQueryConduitAPIMethod.php

Loading...
View Options

src/applications/conduit/query/PhabricatorConduitMethodQuery.php

Loading...
View Options

src/applications/paste/editor/PhabricatorPasteEditEngine.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngineAPIMethod.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php

Loading...
Phabricator · Built by Phacility