Page MenuHomePhabricator
Differential D14455

Fix a potentially lax hash comparison
ClosedPublic
Actions

Authored by epriestley on Nov 10 2015, 5:58 PM.
Tags
None
Referenced Files
F13195460: D14455.diff
Sun, May 12, 10:24 PM
F13193987: D14455.id.diff
Sun, May 12, 8:20 PM
F13184102: D14455.id34949.diff
Fri, May 10, 3:16 PM
F13184033: D14455.id34952.diff
Fri, May 10, 2:25 PM
F13178216: D14455.diff
Wed, May 8, 8:16 PM
Unknown Object (File)
Sat, Apr 27, 10:39 PM
Unknown Object (File)
Thu, Apr 25, 1:41 AM
Unknown Object (File)
Fri, Apr 19, 7:30 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPb3d3130b718d: Fix a potentially lax hash comparison
Summary

Via HackerOne. See D14025. I missed this comparison when making the original change.

Test Plan
  • Used cat mail.txt | scripts/mail/mail_handler.php --process-duplicates to pipe mail in a whole lot of times.
  • Tried bad hashes, saw rejections.
  • Tried good hash, saw mail accepted.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34949.Nov 10 2015, 5:58 PM
epriestley retitled this revision from to Fix a potentially lax hash comparison.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Nov 10 2015, 6:19 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 10 2015, 6:19 PM
Closed by commit rPb3d3130b718d: Fix a potentially lax hash comparison (authored by epriestley, committed by epriestley). · Explain WhyNov 10 2015, 6:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
metamta/
receiver/
2 lines

Diff 34952

View Options

src/applications/metamta/receiver/PhabricatorObjectMailReceiver.php

Loading...
Phabricator · Built by Phacility