Fix a potentially lax hash comparison
ClosedPublic
Actions

Authored by epriestley on Nov 10 2015, 5:58 PM.

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rPb3d3130b718d: Fix a potentially lax hash comparison

Summary

Via HackerOne. See D14025. I missed this comparison when making the original change.

Test Plan

Used cat mail.txt | scripts/mail/mail_handler.php --process-duplicates to pipe mail in a whole lot of times.
Tried bad hashes, saw rejections.
Tried good hash, saw mail accepted.

Diff Detail

Repository

rP Phabricator

Branch

mailhash1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8759
Build 10189: Run Core Tests
Build 10188: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34949.Nov 10 2015, 5:58 PM

epriestley retitled this revision from to Fix a potentially lax hash comparison.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Nov 10 2015, 6:19 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 10 2015, 6:19 PM

Closed by commit rPb3d3130b718d: Fix a potentially lax hash comparison (authored by epriestley, committed by epriestley). · Explain WhyNov 10 2015, 6:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

receiver/

PhabricatorObjectMailReceiver.php

2 lines

Diff 34949

View Options

src/applications/metamta/receiver/PhabricatorObjectMailReceiver.php

Fix a potentially lax hash comparisonClosedPublicActions