Page MenuHomePhabricator

Fix a potentially lax hash comparison
ClosedPublic

Authored by epriestley on Nov 10 2015, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 25, 6:35 AM
Unknown Object (File)
Thu, May 8, 6:25 AM
Unknown Object (File)
May 5 2025, 3:25 AM
Unknown Object (File)
Apr 28 2025, 5:06 PM
Unknown Object (File)
Apr 27 2025, 3:23 PM
Unknown Object (File)
Apr 22 2025, 11:27 AM
Unknown Object (File)
Apr 21 2025, 6:47 PM
Unknown Object (File)
Apr 21 2025, 5:00 PM
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPb3d3130b718d: Fix a potentially lax hash comparison
Summary

Via HackerOne. See D14025. I missed this comparison when making the original change.

Test Plan
  • Used cat mail.txt | scripts/mail/mail_handler.php --process-duplicates to pipe mail in a whole lot of times.
  • Tried bad hashes, saw rejections.
  • Tried good hash, saw mail accepted.

Diff Detail

Repository
rP Phabricator
Branch
mailhash1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8759
Build 10189: Run Core Tests
Build 10188: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix a potentially lax hash comparison.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 10 2015, 6:19 PM
This revision was automatically updated to reflect the committed changes.