Paths

Table of Contentst

Differential D14445

Remove the `PhortuneNotImplementedException` class
ClosedPublic
Actions

Authored by joshuaspence on Nov 9 2015, 10:20 AM.

Tags

None

Referenced Files

	F15461424: D14445.id.diff
	Tue, Apr 1, 8:13 AM

	F15457717: D14445.id34981.diff
	Sun, Mar 30, 6:06 PM

	F15428805: D14445.id34912.diff
	Sun, Mar 23, 10:28 PM

	F15416430: D14445.diff
	Thu, Mar 20, 11:02 AM

	F15411290: D14445.diff
	Wed, Mar 19, 8:58 AM

	F15411239: D14445.diff
	Wed, Mar 19, 8:56 AM

	F15411172: D14445.diff
	Wed, Mar 19, 8:53 AM

	F15411036: D14445.diff
	Wed, Mar 19, 8:48 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPbb9b25a7ba79: Remove the `PhortuneNotImplementedException` class

Summary

Replace PhortuneNotImplementedException with PhutilMethodNotImplementedException.

Test Plan

N/A

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8723
Build 10131: Run Core Tests
Build 10130: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	643 ms	PhabricatorLibraryTestCase::Unknown Unit Message ("")
	1,937 ms	PhabricatorLibraryTestCase::Unknown Unit Message ("")
	125 ms	PhabricatorLibraryTestCase::Unknown Unit Message ("")
	0 ms	AlmanacNamesTestCase::Unknown Unit Message ("")
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("")
		View Full Test Results (3 Failed · 296 Passed)

Event Timeline

joshuaspence updated this revision to Diff 34912.Nov 9 2015, 10:20 AM

joshuaspence retitled this revision from to Remove the `PhortuneNotImplementedException` class.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 9 2015, 10:20 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 9 2015, 3:13 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 9 2015, 3:13 PM

Closed by commit rPbb9b25a7ba79: Remove the `PhortuneNotImplementedException` class (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 11 2015, 7:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

__phutil_library_map__.php

2 lines

-

-

applications/

phortune/

exception/

PhortuneNotImplementedException.php

-

-

provider/

PhortunePaymentProvider.php

16 lines

6%

Loading...

Diff 34912

src/__phutil_library_map__.php

Loading...

src/applications/phortune/exception/PhortuneNotImplementedException.php

Loading...

src/applications/phortune/provider/PhortunePaymentProvider.php

Loading...