Page MenuHomePhabricator
Differential D14445

Remove the `PhortuneNotImplementedException` class
ClosedPublic
Actions

Authored by joshuaspence on Nov 9 2015, 10:20 AM.
Tags
None
Referenced Files
F14045314: D14445.diff
Wed, Nov 13, 2:48 AM
F14029314: D14445.id34981.diff
Fri, Nov 8, 8:26 PM
F14029313: D14445.id34912.diff
Fri, Nov 8, 8:26 PM
F14029312: D14445.id.diff
Fri, Nov 8, 8:26 PM
F14019402: D14445.id34981.diff
Tue, Nov 5, 10:02 PM
F14019401: D14445.id34912.diff
Tue, Nov 5, 10:02 PM
F14019400: D14445.id.diff
Tue, Nov 5, 10:02 PM
F14016556: D14445.diff
Mon, Nov 4, 10:05 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPbb9b25a7ba79: Remove the `PhortuneNotImplementedException` class
Summary

Replace PhortuneNotImplementedException with PhutilMethodNotImplementedException.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8723
Build 10131: Run Core Tests
Build 10130: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
643 msPhabricatorLibraryTestCase::Unknown Unit Message ("")
1,937 msPhabricatorLibraryTestCase::Unknown Unit Message ("")
125 msPhabricatorLibraryTestCase::Unknown Unit Message ("")
0 msAlmanacNamesTestCase::Unknown Unit Message ("")
0 msAlmanacServiceTypeTestCase::Unknown Unit Message ("")
View Full Test Results (3 Failed · 296 Passed)

Event Timeline

joshuaspence updated this revision to Diff 34912.Nov 9 2015, 10:20 AM
joshuaspence retitled this revision from to Remove the `PhortuneNotImplementedException` class.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 9 2015, 10:20 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 9 2015, 3:13 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 9 2015, 3:13 PM
Closed by commit rPbb9b25a7ba79: Remove the `PhortuneNotImplementedException` class (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 11 2015, 7:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
2 lines--
applications/
phortune/
exception/
--
provider/
16 lines6%
Loading...

Diff 34912

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phortune/exception/PhortuneNotImplementedException.php

Loading...
View Options

src/applications/phortune/provider/PhortunePaymentProvider.php

Loading...
Phabricator · Built by Phacility