Page MenuHomePhabricator
Differential D14375

Fix a translation
ClosedPublic
Actions

Authored by joshuaspence on Nov 1 2015, 8:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 3:29 PM
Unknown Object (File)
Thu, Jan 30, 3:29 PM
Unknown Object (File)
Wed, Jan 29, 4:22 PM
Unknown Object (File)
Tue, Jan 28, 3:56 AM
Unknown Object (File)
Tue, Jan 28, 3:56 AM
Unknown Object (File)
Tue, Jan 28, 3:56 AM
Unknown Object (File)
Tue, Jan 28, 3:56 AM
Unknown Object (File)
Fri, Jan 24, 9:35 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9655: Incorrect translation for differential revisions
Commits
Restricted Diffusion Commit
rPaf7b16248e19: Fix a translation
Summary

Fixes T9655.

Test Plan

I haven't tested this... it seems simple enough.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8626
Build 9981: Run Core Tests
Build 9980: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
17 msPhabricatorRepositoryURITestCase::Unknown Unit Message ("")
0 msAlmanacNamesTestCase::Unknown Unit Message ("")
0 msAlmanacServiceTypeTestCase::Unknown Unit Message ("")
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
View Full Test Results (1 Failed · 297 Passed)

Event Timeline

joshuaspence updated this revision to Diff 34707.Nov 1 2015, 8:34 PM
joshuaspence retitled this revision from to Fix a translation.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T9655: Incorrect translation for differential revisions.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 1 2015, 8:34 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley requested changes to this revision.Nov 2 2015, 12:01 AM
epriestley edited edge metadata.

That test failure is legitimately caused by your local 665a0ea.

This revision now requires changes to proceed.Nov 2 2015, 12:01 AM
joshuaspence updated this revision to Diff 34745.Nov 2 2015, 8:26 PM
joshuaspence edited edge metadata.

Rebase

epriestley requested changes to this revision.Nov 2 2015, 8:37 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
818–823

This is really the problem -- missing an extra array() since the first %s is not variant.

This revision now requires changes to proceed.Nov 2 2015, 8:37 PM
joshuaspence added inline comments.Nov 2 2015, 8:38 PM
src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
818–823

What do you mean "the problem"? The unit tests are passing now?

epriestley added a comment.Nov 2 2015, 8:39 PM

You observed an incorrect translation in email subject lines, and fixed an incorrect translation in Doorkeeper (task names in Jira/Asana). This change won't affect email and won't fix T9655. The translation on line 818 is the one to fix to fix email.

joshuaspence updated this revision to Diff 34817.Nov 5 2015, 9:52 AM
joshuaspence edited edge metadata.
joshuaspence marked 2 inline comments as done.

Derp

epriestley accepted this revision.Nov 5 2015, 2:48 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 5 2015, 2:48 PM
Closed by commit rPaf7b16248e19: Fix a translation (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 6 2015, 2:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
infrastructure/
internationalization/
translation/
6 lines0%
Loading...

Diff 34817

View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility