Correct the handle URI for build steps
ClosedPublic
Actions

Authored by epriestley on Oct 30 2015, 2:35 PM.

Details

Reviewers

joshuaspence
chad

Maniphest Tasks

T9674: "Authorized By" links to a 404

Commits

Restricted Diffusion Commit
rP1b8337871b88: Correct the handle URI for build steps

Summary

Fixes T9674. This was wrong to start with (URI is /edit/X/, not /X/edit/) but we have a new view page anyway.

Test Plan

Visited an exmaple URI in my browser.
Followed a build step link from "Authorized By: ..." in Drydock.

Diff Detail

Repository

rP Phabricator

Branch

huri1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8494
Build 9788: Run Core Tests
Build 9787: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34687.Oct 30 2015, 2:35 PM

epriestley retitled this revision from to Correct the handle URI for build steps.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, joshuaspence.

epriestley added a task: T9674: "Authorized By" links to a 404.

chad accepted this revision.Oct 30 2015, 3:53 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 30 2015, 3:53 PM

Closed by commit rP1b8337871b88: Correct the handle URI for build steps (authored by epriestley, committed by epriestley). · Explain WhyOct 30 2015, 3:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

phid/

HarbormasterBuildStepPHIDType.php

2 lines

Diff 34687

View Options

src/applications/harbormaster/phid/HarbormasterBuildStepPHIDType.php

Correct the handle URI for build stepsClosedPublicActions