Fix a check when deciding to destroy the local branch after "arc land"
ClosedPublic
Actions

Authored by epriestley on Oct 28 2015, 5:06 PM.

Details

Reviewers

chad

Maniphest Tasks

T9660: arc land does not delete landed branch when landing directly to remote

Commits

rARC411a4f4a3917: Fix a check when deciding to destroy the local branch after "arc land"

Summary

Fixes T9660. The behavior for this check wasn't quite right -- we want to check the "source ref" (what we're landing) against the "target onto" (the branch we're landing it onto).

Test Plan

Landed from master (tracking origin/master). No delete.
Landed from feature1 (tracking local/master). Delete.
Landed from feature2 (tracking origin/master). Delete.

Diff Detail

Repository

rARC Arcanist

Branch

land3

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/land/ArcanistGitLandEngine.php:319	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 8472
Build 9756: Run Core Tests
Build 9755: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34665.Oct 28 2015, 5:06 PM

epriestley retitled this revision from to Fix a check when deciding to destroy the local branch after "arc land".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9660: arc land does not delete landed branch when landing directly to remote.

chad accepted this revision.Oct 28 2015, 5:07 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 28 2015, 5:07 PM

Closed by commit rARC411a4f4a3917: Fix a check when deciding to destroy the local branch after "arc land" (authored by epriestley, committed by epriestley). · Explain WhyOct 28 2015, 5:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

land/

ArcanistGitLandEngine.php

14 lines

Diff 34665

View Options

src/land/ArcanistGitLandEngine.php

Fix a check when deciding to destroy the local branch after "arc land"ClosedPublicActions