Page MenuHomePhabricator
Differential D14358

Fix a check when deciding to destroy the local branch after "arc land"
ClosedPublic
Actions

Authored by epriestley on Oct 28 2015, 5:06 PM.
Tags
None
Referenced Files
F15537853: D14358.id34665.diff
Thu, Apr 24, 4:08 PM
F15533922: D14358.id.diff
Wed, Apr 23, 10:41 PM
F15533921: D14358.diff
Wed, Apr 23, 10:41 PM
F15522792: D14358.id34665.diff
Sun, Apr 20, 9:26 PM
F15522577: D14358.id34666.diff
Sun, Apr 20, 8:39 PM
F15522576: D14358.id.diff
Sun, Apr 20, 8:39 PM
F15522575: D14358.diff
Sun, Apr 20, 8:39 PM
F15498480: D14358.id34665.diff
Sun, Apr 13, 1:01 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9660: arc land does not delete landed branch when landing directly to remote
Commits
rARC411a4f4a3917: Fix a check when deciding to destroy the local branch after "arc land"
Summary

Fixes T9660. The behavior for this check wasn't quite right -- we want to check the "source ref" (what we're landing) against the "target onto" (the branch we're landing it onto).

Test Plan
  • Landed from master (tracking origin/master). No delete.
  • Landed from feature1 (tracking local/master). Delete.
  • Landed from feature2 (tracking origin/master). Delete.

Diff Detail

Repository
rARC Arcanist
Branch
land3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/land/ArcanistGitLandEngine.php:319XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 8472
Build 9756: Run Core Tests
Build 9755: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34665.Oct 28 2015, 5:06 PM
epriestley retitled this revision from to Fix a check when deciding to destroy the local branch after "arc land".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9660: arc land does not delete landed branch when landing directly to remote.
chad accepted this revision.Oct 28 2015, 5:07 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 28 2015, 5:07 PM
Closed by commit rARC411a4f4a3917: Fix a check when deciding to destroy the local branch after "arc land" (authored by epriestley, committed by epriestley). · Explain WhyOct 28 2015, 5:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
land/
14 lines

Diff 34665

View Options

src/land/ArcanistGitLandEngine.php

Loading...
Phabricator · Built by Phacility