Page MenuHomePhabricator
Differential D14353

Allow ObjectLists to be set to Dialogs
ClosedPublic
Actions

Authored by chad on Oct 27 2015, 7:30 PM.
Tags
None
Referenced Files
F14031422: D14353.diff
Sat, Nov 9, 10:25 AM
F14026431: D14353.id34648.diff
Fri, Nov 8, 1:18 AM
F14026430: D14353.id34647.diff
Fri, Nov 8, 1:18 AM
F14026429: D14353.id.diff
Fri, Nov 8, 1:18 AM
F14026428: D14353.diff
Fri, Nov 8, 1:18 AM
F14016368: D14353.id34648.diff
Mon, Nov 4, 8:31 AM
F14016367: D14353.id.diff
Mon, Nov 4, 8:30 AM
F14016366: D14353.id34647.diff
Mon, Nov 4, 8:30 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP218ab398b0ef: Allow ObjectLists to be set to Dialogs
Summary

Better formatting for object lists when in a dialog (like subscribers).

Test Plan

Test a subscription list.

Screen Shot 2015-10-27 at 12.28.19 PM.png (1×1 px, 125 KB)

Diff Detail

Repository
rP Phabricator
Branch
dialog-list
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8455
Build 9727: Run Core Tests
Build 9726: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34647.Oct 27 2015, 7:30 PM
chad retitled this revision from to Allow ObjectLists to be set to Dialogs.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 27 2015, 7:30 PM
chad edited the test plan for this revision. (Show Details)Oct 27 2015, 7:30 PM
epriestley accepted this revision.Oct 27 2015, 7:31 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 27 2015, 7:31 PM
chad added a comment.Oct 27 2015, 7:31 PM

are you pushing the button or should i?

epriestley added a comment.Oct 27 2015, 7:32 PM

All yours, but I am reloading the page over and over again so I get to see it.

Closed by commit rP218ab398b0ef: Allow ObjectLists to be set to Dialogs (authored by chad, committed by chad). · Explain WhyOct 27 2015, 7:32 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Oct 27 2015, 7:33 PM

Very satisfying.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
subscriptions/
view/
5 lines
view/
24 lines
webroot/
rsrc/
css/
aphront/
10 lines

Diff 34647

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/subscriptions/view/SubscriptionListDialogBuilder.php

Loading...
View Options

src/view/AphrontDialogView.php

Loading...
View Options

webroot/rsrc/css/aphront/dialog-view.css

Loading...
Phabricator · Built by Phacility