Differential D14338

Show the oldest non-failing revision land operation, or the newest failure
ClosedPublic
Actions

Authored by epriestley on Oct 25 2015, 11:23 PM.

Tags

None

Referenced Files

	F16807885: D14338.id34624.diff
	Wed, Jun 18, 5:23 AM

	F16743916: D14338.diff
	Tue, Jun 17, 9:21 PM

	Unknown Object (File)
	Sun, Jun 1, 4:38 AM

	Unknown Object (File)
	Thu, May 29, 12:31 PM

	Unknown Object (File)
	Tue, May 27, 10:08 PM

	Unknown Object (File)
	Mon, May 26, 7:00 PM

	Unknown Object (File)
	Sun, May 25, 6:33 AM

	Unknown Object (File)
	May 3 2025, 8:16 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T182: Commit into repository directly from differential

Commits

Restricted Diffusion Commit
rPa0fba642b382: Show the oldest non-failing revision land operation, or the newest failure

Summary

Ref T182.

We just show the oldest operation right now, but we usually care about the oldest non-failure.
Only query for actual land operations when rendering the revision operations dialog (maybe eventually we'll show more stuff?).
For now, prevent multiple lands / repeated lands or queueing up lands while other lands are happening.

Test Plan

Landed a revision. Tried to land it more / again.

Diff Detail

Repository

Branch

workmerge2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8432
Build 9692: Run Core Tests
Build 9691: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34604.Oct 25 2015, 11:23 PM

epriestley retitled this revision from to Show the oldest non-failing revision land operation, or the newest failure.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T182: Commit into repository directly from differential.

chad accepted this revision.Oct 26 2015, 4:45 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 26 2015, 4:45 PM

Rebase.

Closed by commit rPa0fba642b382: Show the oldest non-failing revision land operation, or the newest failure (authored by epriestley, committed by epriestley). · Explain WhyOct 26 2015, 7:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionOperationController.php

44 lines

DifferentialRevisionViewController.php

15 lines

drydock/

query/

DrydockRepositoryOperationQuery.php

13 lines

storage/

DrydockRepositoryOperation.php

4 lines

Diff 34623

src/applications/differential/controller/DifferentialRevisionOperationController.php

Loading...

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...

src/applications/drydock/query/DrydockRepositoryOperationQuery.php

Loading...

src/applications/drydock/storage/DrydockRepositoryOperation.php

Loading...