Differential D14338

Show the oldest non-failing revision land operation, or the newest failure
ClosedPublic
Actions

Authored by epriestley on Oct 25 2015, 11:23 PM.

Tags

None

Referenced Files

	F19509435: D14338.diff
	Sat, Jan 10, 7:53 PM

	F19303227: D14338.id.diff
	Tue, Dec 23, 9:12 PM

	F19262508: D14338.diff
	Mon, Dec 22, 5:52 PM

	F19041231: D14338.id34604.diff
	Nov 26 2025, 3:12 PM

	F19040819: D14338.id34623.diff
	Nov 26 2025, 1:41 PM

	F19040342: D14338.diff
	Nov 26 2025, 12:26 PM

	F18814509: D14338.diff
	Oct 20 2025, 11:23 PM

	F18793331: D14338.id.diff
	Oct 16 2025, 9:12 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T182: Commit into repository directly from differential

Commits

Restricted Diffusion Commit
rPa0fba642b382: Show the oldest non-failing revision land operation, or the newest failure

Summary

Ref T182.

We just show the oldest operation right now, but we usually care about the oldest non-failure.
Only query for actual land operations when rendering the revision operations dialog (maybe eventually we'll show more stuff?).
For now, prevent multiple lands / repeated lands or queueing up lands while other lands are happening.

Test Plan

Landed a revision. Tried to land it more / again.

Diff Detail

Repository

Branch

workmerge2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8413
Build 9669: Run Core Tests
Build 9668: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34604.Oct 25 2015, 11:23 PM

epriestley retitled this revision from to Show the oldest non-failing revision land operation, or the newest failure.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T182: Commit into repository directly from differential.

chad accepted this revision.Oct 26 2015, 4:45 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 26 2015, 4:45 PM

Rebase.

Closed by commit rPa0fba642b382: Show the oldest non-failing revision land operation, or the newest failure (authored by epriestley, committed by epriestley). · Explain WhyOct 26 2015, 7:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionOperationController.php

44 lines

DifferentialRevisionViewController.php

15 lines

drydock/

query/

DrydockRepositoryOperationQuery.php

13 lines

storage/

DrydockRepositoryOperation.php

4 lines

Diff 34604

src/applications/differential/controller/DifferentialRevisionOperationController.php

Loading...

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...

src/applications/drydock/query/DrydockRepositoryOperationQuery.php

Loading...

src/applications/drydock/storage/DrydockRepositoryOperation.php

Loading...