Differential D14340

Fix T9635 by initializing the property
ClosedPublic
Actions

Authored by Mnkras on Oct 26 2015, 4:48 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9635: arc unit throws when there are no tests to run on PHP7

Commits

rARC3308da5f8fbe: Fix T9635 by initializing the property

Summary

Fix T9635 by properly initializing a property

Test Plan

run arc unit

Diff Detail

Repository

rARC Arcanist

Branch

fix-arc-unit-php7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8416
Build 9673: arc lint + arc unit

Event Timeline

Mnkras updated this revision to Diff 34607.Oct 26 2015, 4:48 PM

Mnkras retitled this revision from to Fix T9635 by initializing the property.

Mnkras updated this object.

Mnkras edited the test plan for this revision. (Show Details)

Mnkras added a task: T9635: arc unit throws when there are no tests to run on PHP7.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 26 2015, 4:48 PM

Herald added a subscriber: epriestley. · View Herald Transcript

epriestley accepted this revision.Oct 26 2015, 4:48 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.Oct 26 2015, 4:48 PM

Closed by commit rARC3308da5f8fbe: Fix T9635 by initializing the property (authored by Mnkras, committed by epriestley). · Explain WhyOct 26 2015, 4:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

unit/

engine/

ArcanistUnitTestEngine.php

2 lines

Diff 34607

View Options

src/unit/engine/ArcanistUnitTestEngine.php

Fix T9635 by initializing the propertyClosedPublicActions