Page MenuHomePhabricator

Show the oldest non-failing revision land operation, or the newest failure
ClosedPublic

Authored by epriestley on Oct 25 2015, 11:23 PM.
Tags
None
Referenced Files
F19040342: D14338.diff
Wed, Nov 26, 12:26 PM
F18814509: D14338.diff
Oct 20 2025, 11:23 PM
F18793331: D14338.id.diff
Oct 16 2025, 9:12 PM
F18754530: D14338.id34624.diff
Oct 4 2025, 11:22 PM
F18673126: D14338.id34623.diff
Sep 25 2025, 9:25 AM
F18658350: D14338.diff
Sep 23 2025, 6:00 AM
F18605825: D14338.id.diff
Sep 13 2025, 9:24 PM
F18594728: D14338.diff
Sep 12 2025, 7:09 PM
Subscribers
None

Details

Summary

Ref T182.

  • We just show the oldest operation right now, but we usually care about the oldest non-failure.
  • Only query for actual land operations when rendering the revision operations dialog (maybe eventually we'll show more stuff?).
  • For now, prevent multiple lands / repeated lands or queueing up lands while other lands are happening.
Test Plan

Landed a revision. Tried to land it more / again.

Diff Detail

Repository
rP Phabricator
Branch
workmerge2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8413
Build 9669: Run Core Tests
Build 9668: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Show the oldest non-failing revision land operation, or the newest failure.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 26 2015, 4:45 PM
This revision was automatically updated to reflect the committed changes.