Page MenuHomePhabricator

Make WorkingCopyBlueprint responsible for performing merges
ClosedPublic

Authored by epriestley on Oct 25 2015, 11:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 8:36 AM
Unknown Object (File)
Tue, May 7, 1:37 AM
Unknown Object (File)
Tue, May 7, 1:37 AM
Unknown Object (File)
Tue, May 7, 1:37 AM
Unknown Object (File)
Fri, May 3, 8:10 AM
Unknown Object (File)
Tue, Apr 30, 8:27 AM
Unknown Object (File)
Thu, Apr 25, 2:23 AM
Unknown Object (File)
Sun, Apr 21, 3:24 AM
Subscribers
None

Details

Summary

Ref T182. Currently, the "RepositoryLand" operation is responsible for performing merges when landing a revision.

However, we'd like to be able to perform these merges in a larger set of cases in the future. For example:

  • After Releeph is revamped, when someone says "I want to merge bug fix X into stable branch Y", it would probably be nice to make that a Buildable and let tests run against it without requring that it actually be pushed anywhere.
  • Same deal if we want a merge-from-Diffusion or cherry-pick-from-Diffusion operation.
  • Similar deal if we want a "random web UI edits from Diffusion".

Move the merging part into WorkingCopy so more applications can share/use it in the future.

A big chunk of this is me making stuff up for now (the ol' undocumented dictionary full of arbitrary magic keys), but I anticipate formalizing it as we move along.

Test Plan

Pushed rGITTEST0d58eef3ce0fa5a10732d2efefc56aec126bc219 up from my local install via "Land Revision".

Diff Detail

Repository
rP Phabricator
Branch
workmerge1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8412
Build 9667: Run Core Tests
Build 9666: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Make WorkingCopyBlueprint responsible for performing merges.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 26 2015, 7:33 PM
This revision was automatically updated to reflect the committed changes.