Differential D14324

Provide an application link for the Macro PHID type
ClosedPublic
Actions

Authored by epriestley on Oct 24 2015, 1:16 PM.

Details

Reviewers

chad

Maniphest Tasks

T9625: Fill in missing applications and icons on PHID types

Commits

Restricted Diffusion Commit
rPd0098bc43626: Provide an application link for the Macro PHID type

Summary

Ref T9625. This is an example of how to fill in the missing calls.

Test Plan

Verified that an icon is now shown for feed stories.
Verified that an icon is now shown in the "PHID Types" module panel in Config.

Screen Shot 2015-10-24 at 6.14.17 AM.png (128×329 px, 15 KB)

Diff Detail

Repository

rP Phabricator

Branch

feedimage2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8389
Build 9633: Run Core Tests
Build 9632: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34577.Oct 24 2015, 1:16 PM

epriestley retitled this revision from to Provide an application link for the Macro PHID type.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9625: Fill in missing applications and icons on PHID types.

epriestley mentioned this in T9625: Fill in missing applications and icons on PHID types.Oct 24 2015, 1:18 PM

chad accepted this revision.Oct 24 2015, 4:27 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 24 2015, 4:27 PM

Closed by commit rPd0098bc43626: Provide an application link for the Macro PHID type (authored by epriestley, committed by epriestley). · Explain WhyOct 24 2015, 4:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

phid/

PhabricatorMacroMacroPHIDType.php

4 lines

Diff 34577

View Options

src/applications/macro/phid/PhabricatorMacroMacroPHIDType.php

Provide an application link for the Macro PHID typeClosedPublicActions