Differential D14323

Show applications and icons for PHID types in config table
ClosedPublic
Actions

Authored by epriestley on Oct 24 2015, 1:13 PM.

Details

Reviewers

chad

Maniphest Tasks

T9625: Fill in missing applications and icons on PHID types

Commits

Restricted Diffusion Commit
rP58957e62c1fa: Show applications and icons for PHID types in config table

Summary

Ref T9625. Some PHID types are missing application or icon specifications. This makes it easier to spot them.

Test Plan

Screen Shot 2015-10-24 at 6.11.19 AM.png (1×1 px, 328 KB)

Diff Detail

Repository

rP Phabricator

Branch

feedimage1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8388
Build 9631: Run Core Tests
Build 9630: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34576.Oct 24 2015, 1:13 PM

epriestley retitled this revision from to Show applications and icons for PHID types in config table.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9625: Fill in missing applications and icons on PHID types.

epriestley mentioned this in T9625: Fill in missing applications and icons on PHID types.Oct 24 2015, 1:18 PM

Oh I see

This revision is now accepted and ready to land.Oct 24 2015, 3:14 PM

Closed by commit rP58957e62c1fa: Show applications and icons for PHID types in config table (authored by epriestley, committed by epriestley). · Explain WhyOct 24 2015, 3:16 PM

This revision was automatically updated to reflect the committed changes.

revi mentioned this in D14331: Provide an application link for Ponder Answer PHID type.Oct 25 2015, 12:43 AM

epriestley mentioned this in rPa39ec26a672a: Provide an application link for Ponder Answer PHID type.Oct 25 2015, 1:12 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

module/

PhabricatorConfigPHIDModule.php

32 lines

Diff 34576

View Options

src/applications/config/module/PhabricatorConfigPHIDModule.php

Show applications and icons for PHID types in config tableClosedPublicActions