Page MenuHomePhabricator
Differential D14304

Don't allow logged out users to initialize a Workboard
ClosedPublic
Actions

Authored by chad on Oct 19 2015, 7:02 PM.
Tags
None
Referenced Files
F15467169: D14304.id34527.diff
Thu, Apr 3, 1:26 PM
F15463730: D14304.id34526.diff
Wed, Apr 2, 2:31 AM
F15439373: D14304.id.diff
Wed, Mar 26, 7:15 AM
F15433546: D14304.diff
Mon, Mar 24, 11:44 PM
F15421815: D14304.diff
Sat, Mar 22, 2:21 AM
F15421120: D14304.diff
Fri, Mar 21, 9:10 PM
F15419097: D14304.id.diff
Fri, Mar 21, 3:27 AM
F15404519: D14304.diff
Tue, Mar 18, 8:05 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)"
Commits
Restricted Diffusion Commit
rP267e718dfe2f: Don't allow logged out users to initialize a Workboard
Summary

Right now logged out users can enable a workboard on a project.

Test Plan

Log out, view a public project, click on Workboard, get not set up dialog. Click Cancel, return to project details.

Diff Detail

Repository
rP Phabricator
Branch
logged-out-wb
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8339
Build 9564: Run Core Tests
Build 9563: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34526.Oct 19 2015, 7:02 PM
chad retitled this revision from to Don't allow logged out users to initialize a Workboard.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 19 2015, 7:02 PM
epriestley accepted this revision.Oct 19 2015, 7:03 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 19 2015, 7:03 PM
Closed by commit rP267e718dfe2f: Don't allow logged out users to initialize a Workboard (authored by chad, committed by chad). · Explain WhyOct 19 2015, 7:12 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Oct 19 2015, 7:33 PM

Oh, I guess this should be can_edit

epriestley added a comment.Oct 19 2015, 8:15 PM

Probably some new permission after T6502, you could maybe just leave it as is until we get there since that's maybe-in-theory some time this year.

chad added a task: T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)".Oct 19 2015, 8:22 PM

Revision Contents
Changeset List

PathSize
src/
applications/
project/
controller/
17 lines

Diff 34526

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
Phabricator · Built by Phacility