Page MenuHomePhabricator

Don't allow logged out users to initialize a Workboard
ClosedPublic

Authored by chad on Oct 19 2015, 7:02 PM.

Details

Summary

Right now logged out users can enable a workboard on a project.

Test Plan

Log out, view a public project, click on Workboard, get not set up dialog. Click Cancel, return to project details.

Diff Detail

Repository
rP Phabricator
Branch
logged-out-wb
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8339
Build 9564: Run Core Tests
Build 9563: arc lint + arc unit

Event Timeline

chad retitled this revision from to Don't allow logged out users to initialize a Workboard.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 19 2015, 7:03 PM
This revision was automatically updated to reflect the committed changes.

Oh, I guess this should be can_edit

Probably some new permission after T6502, you could maybe just leave it as is until we get there since that's maybe-in-theory some time this year.