Details
Details
- Verified runtime improvement by comparing scripts/highlight.php on the one-line.json test case from D14273 with the new lexer enabled and commented out. Saw >10x local improvement. My local base runtime is also >10x better than the runtime from D14273. My laptop might be a little faster than whatever that hardware was, but this is probably mostly pygmentize improvements in my most recent version.
- Added a test case.
- Used the highlighter to produce reasonable-looking results:
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- json1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8310 Build 9530: Run Core Tests Build 9529: arc lint + arc unit
Event Timeline
Comment Actions
Actually, just fix lint by excluding __tests__/data/, which seems reasonable for all similar cases.
Comment Actions
(I'm going to hold this until the release cut tomorrow morning since some issues might crop up once it gets a little more use and it sounds like "upgrade pygments" fixed most of this anyway.)