Page MenuHomePhabricator

Use Drydock authorizations when acquiring leases
ClosedPublic

Authored by epriestley on Oct 12 2015, 1:26 PM.
Tags
None
Referenced Files
F14033975: D14254.diff
Sat, Nov 9, 9:06 PM
F14025802: D14254.id34416.diff
Thu, Nov 7, 8:29 PM
F14025797: D14254.id34427.diff
Thu, Nov 7, 8:26 PM
F14025790: D14254.id.diff
Thu, Nov 7, 8:22 PM
F14025781: D14254.id34416.diff
Thu, Nov 7, 8:11 PM
F14025778: D14254.diff
Thu, Nov 7, 8:08 PM
F14025774: D14254.id34427.diff
Thu, Nov 7, 8:05 PM
F14025771: D14254.id.diff
Thu, Nov 7, 8:04 PM
Subscribers
None

Details

Summary

Ref T9519. When acquiring leases on resources:

  • Only consider resources created by authorized blueprints.
  • Only consider authorized blueprints when creating new resources.
  • Fail with a tailored error if no blueprints are allowed.
  • Fail with a tailored error if missing authorizations are causing acquisition failure.

One somewhat-substantial issue with this is that it's pretty hard to figure out from the Harbormaster side. Specifically, the Build step UI does not show field value anywhere, so the presence of unapproved blueprints is not communicated. This is much more clear in Drydock. I'll plan to address this in future changes to Harbormaster, since there are other related/similar issues anyway.

Test Plan

Screen Shot 2015-10-12 at 5.43.47 AM.png (272×1 px, 51 KB)

Diff Detail

Repository
rP Phabricator
Branch
dauth2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/drydock/management/DrydockManagementLeaseWorkflow.php:65XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 8231
Build 9415: Run Core Tests
Build 9414: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Use Drydock authorizations when acquiring leases.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, hach-que.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 12 2015, 2:08 PM
This revision was automatically updated to reflect the committed changes.