Page MenuHomePhabricator
Differential D14248

Put cows and figlet bannners in <pre> in HTML mail bodies
ClosedPublic
Actions

Authored by epriestley on Oct 9 2015, 3:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 10:52 PM
Unknown Object (File)
Wed, Nov 20, 6:45 PM
Unknown Object (File)
Nov 9 2024, 7:02 AM
Unknown Object (File)
Oct 24 2024, 5:04 AM
Unknown Object (File)
Oct 23 2024, 5:11 AM
Unknown Object (File)
Oct 19 2024, 5:08 PM
Unknown Object (File)
Oct 16 2024, 5:29 PM
Unknown Object (File)
Sep 28 2024, 3:46 AM
View All Files
Subscribers
cspeckmim

Details

Reviewers
chad
Maniphest Tasks
T9538: HTML Emails which contain figlet and cowsay content should render respective code blocks in fixed-width font
T9408: Upgrading: `dot` (Graphviz) support removed, changes to `figlet` and `cowsay`
Commits
Restricted Diffusion Commit
rP5a874ba0a840: Put cows and figlet bannners in <pre> in HTML mail bodies
Summary

Fixes T9538. Ref T9408. cowsay and figlet Remarkup rules are being mangled in HTML mail right now. Put them in <pre> to unmangle them.

Test Plan

Sent myself a cow + figlet in mail.

Used bin/mail show-outbound --id ... --dump-html > dump.html + open that HTML file in Safari to preview HTML mail.

Saw linebreaks and monospaced formatting.

Diff Detail

Repository
rP Phabricator
Branch
hmail
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8211
Build 9390: Run Core Tests
Build 9389: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34399.Oct 9 2015, 3:01 AM
epriestley retitled this revision from to Put cows and figlet bannners in <pre> in HTML mail bodies.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9408: Upgrading: `dot` (Graphviz) support removed, changes to `figlet` and `cowsay`.
epriestley updated this object.Oct 9 2015, 3:02 AM
epriestley added a task: T9538: HTML Emails which contain figlet and cowsay content should render respective code blocks in fixed-width font.
chad accepted this revision.Oct 9 2015, 3:02 AM
chad edited edge metadata.
____________ < amoozing > ------------ \ ^__^ \ (oo)\_______ (__)\ )\/\ ||----w | || ||
This revision is now accepted and ready to land.Oct 9 2015, 3:02 AM
epriestley added a comment.Oct 9 2015, 3:03 AM

haha

Closed by commit rP5a874ba0a840: Put cows and figlet bannners in <pre> in HTML mail bodies (authored by epriestley, committed by epriestley). · Explain WhyOct 9 2015, 3:03 AM
This revision was automatically updated to reflect the committed changes.
epriestley added a subscriber: cspeckmim.Oct 9 2015, 3:06 AM
_________________________________ < OooOOoooo!! Happy Halloween!! > --------------------------------- \ ,+*^^*+___+++_ \ ,*^^^^ ) \ _+* ^**+_ \ +^ _ _++*+_+++_, ) _+^^*+_ ( ,+*^ ^ \+_ ) { ) ( ,( ,_+--+--, ^) ^\ { (@) } f ,( ,+-^ __*_*_ ^^\_ ^\ ) {:;-/ (_+*-+^^^^^+*+*<_ _++_)_ ) ) / ( / ( ( ,___ ^*+_+* ) < < \ U _/ ) *--< ) ^\-----++__) ) ) ) ( ) _(^)^^)) ) )\^^^^^))^*+/ / / ( / (_))_^)) ) ) ))^^^^^))^^^)__/ +^^ ( ,/ (^))^)) ) ) ))^^^^^^^))^^) _) *+__+* (_))^) ) ) ))^^^^^^))^^^^^)____*^ \ \_)^)_)) ))^^^^^^^^^^))^^^^) (_ ^\__^^^^^^^^^^^^))^^^^^^^) ^\___ ^\__^^^^^^))^^^^^^^^)\\ ^^^^^\uuu/^^\uuu/^^^^\^\^\^\^\^\^\^\ ___) >____) >___ ^\_\_\_\_\_\_\) ^^^//\\_^^//\\_^ ^(\_\_\_\) ^^^ ^^ ^^^ ^
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ / \ ( H ) a ) v ) e ) ( A ) n ) ( U ) n ) r ) e ) g ) r ) e ) t ) t ) a ) b ) l ) e ) ( B ) o ) x ) i ) n ) g ) ( D ) a ) y ) ! ) \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/ \_/
cspeckmim added a comment.Oct 9 2015, 3:08 AM

lol - I must say I was disappointed to discover that the ghost font wasn't installed:

Screen Shot 2015-10-08 at 11.07.41 PM.png (412×2 px, 78 KB)

epriestley added a comment.Oct 9 2015, 3:11 AM

That is a sweet font!

I'm not sure what the license is for the library at java.de so I'm hesitant to just dump them into externals/ and redistribute them.

epriestley added a comment.Oct 9 2015, 3:12 AM

We should also have some kind of "list of installed cows" and "list of installed figlet fonts" UI somewhere.

chad added a comment.Oct 9 2015, 3:15 AM

put a fax icon next to the meme icon in the remarkup bar, pops a dialog with installed choices

cspeckmim added a comment.Oct 9 2015, 3:17 AM

I was going to diff up a change but had mucked up so much of the mercurial related code that I set it aside (and I'm not super familiar with using git) -- but the resources/cows/custom and resources/figlet/custom folders are not in the .gitignore yet.

cspeckmim added a comment.EditedOct 10 2015, 5:55 PM
In D14248#158126, @epriestley wrote:

That is a sweet font!

I'm not sure what the license is for the library at java.de so I'm hesitant to just dump them into externals/ and redistribute them.

I was referring to being usable here on secure.phabricator.com -- I wouldn't expect anything outside of the OG fonts/cows to ship with Phabricator. That aside, the lack of licensing information would give cause to avoid it either way.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
markup/
interpreter/
8 lines
8 lines

Diff 34399

View Options

src/infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php

Loading...
View Options

src/infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php

Loading...
Phabricator · Built by Phacility