Page MenuHomePhabricator
Differential D14237

Put Drydock build steps into their own group in Harbormaster
ClosedPublic
Actions

Authored by epriestley on Oct 5 2015, 6:17 PM.
Tags
None
Referenced Files
F13161499: D14237.diff
Mon, May 6, 7:48 AM
Unknown Object (File)
Fri, May 3, 9:24 AM
Unknown Object (File)
Thu, May 2, 6:17 PM
Unknown Object (File)
Sat, Apr 27, 4:09 PM
Unknown Object (File)
Thu, Apr 25, 3:01 AM
Unknown Object (File)
Fri, Apr 19, 3:43 PM
Unknown Object (File)
Fri, Apr 12, 5:32 PM
Unknown Object (File)
Wed, Apr 10, 11:54 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9252: Unprototype Drydock (v1)
Commits
Restricted Diffusion Commit
rP4d5278af1148: Put Drydock build steps into their own group in Harbormaster
Summary

Ref T9252. Move these into a new "Drydock" group.

Test Plan

Clicked "Add Build Step", saw Drydock steps in a Drydock group.

Diff Detail

Repository
rP Phabricator
Branch
dock3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8187
Build 9359: Run Core Tests
Build 9358: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34376.Oct 5 2015, 6:17 PM
epriestley retitled this revision from to Put Drydock build steps into their own group in Harbormaster.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9252: Unprototype Drydock (v1).
chad accepted this revision.Oct 5 2015, 7:03 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 5 2015, 7:03 PM
Closed by commit rP4d5278af1148: Put Drydock build steps into their own group in Harbormaster (authored by epriestley, committed by epriestley). · Explain WhyOct 5 2015, 10:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 34376

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanEditController.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterDrydockCommandBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/stepgroup/HarbormasterDrydockBuildStepGroup.php

Loading...
Phabricator · Built by Phacility