Differential D14228

Add Korean locales
ClosedPublic
Actions

Authored by revi on Oct 3 2015, 3:18 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9285: Custom locale may fail when pht a sentence with variants

Commits

rPHUf923eff2dec1: Add Korean locales

Summary

Ref T9285, add Korean locales per epriestley.
Korean have no PLURAL/GENDER normally, but plural left since
a little strings may need some plural expressions.

Test Plan

Have a Korean translation file.
Go settings, no Korean in language selection
Apply Patch
arc liberate, and voila! Now Korean (Republic of Korea) is there

Diff Detail

Repository

rPHU libphutil

Branch

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 8165
Build 9328: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	53 ms	PhutilLibraryTestCase::Unknown Unit Message ("")
	99 ms	PhutilLibraryTestCase::Unknown Unit Message ("")
	1 ms	PhutilLibraryTestCase::Unknown Unit Message ("")
	0 ms	PhutilLocaleTestCase::Unknown Unit Message ("")
	0 ms	PhutilPhtTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 15 Passed)

Event Timeline

revi updated this revision to Diff 34357.Oct 3 2015, 3:18 AM

revi retitled this revision from to Add Korean locales.

revi updated this object.

revi edited the test plan for this revision. (Show Details)

revi added a reviewer: epriestley.

revi added a task: T9285: Custom locale may fail when pht a sentence with variants.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 3 2015, 3:18 AM

Herald added a subscriber: Korvin. · View Herald Transcript

seungrye added a subscriber: seungrye.Oct 3 2015, 7:14 AM

Thanks!

I don't speak Korean so it's difficult for me to be confident that this ruleset is correct, but it seems right from other sources I can find discussing Korean localization, like this one:

Don’t fret over plurals in your Korean translation. If you change the source from singular to plural, go ahead and send it over to your Korean translation team to make sure, but don’t be surprised if no change is required.

http://nojeokhill.koreanconsulting.com/2013/01/korean-translation-tip-korea-has-a-plural-form-it-just-doesnt-get-used-much.html

It looks like Korean does have honorifics, but presumably it's common for software to use some consistent honorific level everywhere? I can't think of any cases where it would be appropriate to change honorifics based on the subject of a sentence.

This revision is now accepted and ready to land.Oct 3 2015, 11:29 AM

Well yes, Korean has plural forms in grammar (~들), but when you count something, plural is not used. (So, "7 differential revisions" is just 7 differential revision (tr: 디퍼런셜 리비전 7개) (in Korean grammar terms) when translated.) (See Wiktionary)

From Wiktionary link above, licensed under CC BY SA 3.0

들 (deul) is rarely used with nouns denoting inanimate objects. It is more often used with nouns denoting animate objects (people and animals), but then only when it is semantically necessary to make a distinction between singular and plural, or to emphasize plurality.

So maybe is it better to only use singular?

For honorifics, translations of software is usually honorific because it would make people feel "this software is commanding me!" or such emotional issues. Windows, MediaWiki, almost all programs I saw translated into Korean uses honorific forms. Simply, only think of honorifics, and you'll be fine.

Closed by commit rPHUf923eff2dec1: Add Korean locales (authored by revi, committed by epriestley). · Explain WhyOct 3 2015, 12:29 PM

This revision was automatically updated to reflect the committed changes.

revi mentioned this in D14229: Set Korean PLURAL rules to singular only..Oct 3 2015, 5:59 PM