Differential D14223

Correct a Dashboard status constant in a migration
ClosedPublic
Actions

Authored by epriestley on Oct 2 2015, 1:13 PM.

Details

Reviewers

chad

Maniphest Tasks

T9500: Active dashboards not shown with "Active" search filter

Commits

Restricted Diffusion Commit
rP3c4b05bcd4b6: Correct a Dashboard status constant in a migration

Summary

Fixes T9500. All the code is fine in D13836, but the value of the constant got updated (from "open" to "active") and the migration still used the old value.

Correct any affected dashboards to use the proper constant.

This only affected old dashboards: newly created ones use the right constant.

Test Plan

Ran migration, verified that all active dashboards appeared on "Active Dashboards".

Diff Detail

Repository

rP Phabricator

Branch

dash1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8152
Build 9312: Run Core Tests
Build 9311: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34344.Oct 2 2015, 1:13 PM

epriestley retitled this revision from to Correct a Dashboard status constant in a migration.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9500: Active dashboards not shown with "Active" search filter.

This revision is now accepted and ready to land.Oct 2 2015, 1:59 PM

Closed by commit rP3c4b05bcd4b6: Correct a Dashboard status constant in a migration (authored by epriestley, committed by epriestley). · Explain WhyOct 2 2015, 4:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20151002.dashboard.status.1.sql

2 lines

Diff 34344

View Options

resources/sql/autopatches/20151002.dashboard.status.1.sql

Correct a Dashboard status constant in a migrationClosedPublicActions