Page MenuHomePhabricator
Differential D14185

Fix an issue with BuildLogs and web UI during builds
ClosedPublic
Actions

Authored by epriestley on Sep 29 2015, 2:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 11:47 AM
Unknown Object (File)
Wed, Nov 20, 11:47 AM
Unknown Object (File)
Wed, Nov 20, 11:47 AM
Unknown Object (File)
Tue, Nov 19, 11:53 PM
Unknown Object (File)
Sun, Nov 17, 8:26 AM
Unknown Object (File)
Sat, Nov 16, 12:16 PM
Unknown Object (File)
Tue, Nov 12, 12:36 AM
Unknown Object (File)
Fri, Nov 8, 10:56 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9123: Build Phabricator in Harbormaster (v2)
Commits
Restricted Diffusion Commit
rPa5c417716056: Fix an issue with BuildLogs and web UI during builds
Summary

Ref T9123. After recent changes, viewing a live build log from the web UI throws a CSRF exception.

Check start ("this object is an active log"), not live ("this log is open somewhere").

Test Plan

Will push / etc.

Diff Detail

Event Timeline

epriestley updated this revision to Diff 34266.Sep 29 2015, 2:10 AM
epriestley retitled this revision from to Fix an issue with BuildLogs and web UI during builds.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9123: Build Phabricator in Harbormaster (v2).
chad accepted this revision.Sep 29 2015, 2:10 AM
chad edited edge metadata.

spodermancoffee

This revision is now accepted and ready to land.Sep 29 2015, 2:10 AM
Closed by commit rPa5c417716056: Fix an issue with BuildLogs and web UI during builds (authored by epriestley, committed by epriestley). · Explain WhySep 29 2015, 2:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
storage/
build/
2 lines

Diff 34266

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...
Phabricator · Built by Phacility