Paths

Table of Contentst

Differential D14185

Fix an issue with BuildLogs and web UI during builds
ClosedPublic
Actions

Authored by epriestley on Sep 29 2015, 2:10 AM.

Details

Reviewers

chad

Maniphest Tasks

T9123: Build Phabricator in Harbormaster (v2)

Commits

Restricted Diffusion Commit
rPa5c417716056: Fix an issue with BuildLogs and web UI during builds

Summary

Ref T9123. After recent changes, viewing a live build log from the web UI throws a CSRF exception.

Check start ("this object is an active log"), not live ("this log is open somewhere").

Test Plan

Will push / etc.

Diff Detail

Repository

rP Phabricator

Branch

dd2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8082
Build 9194: [Placeholder Plan] Wait for 30 Seconds
Build 9193: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34266.Sep 29 2015, 2:10 AM

epriestley retitled this revision from to Fix an issue with BuildLogs and web UI during builds.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9123: Build Phabricator in Harbormaster (v2).

spodermancoffee

This revision is now accepted and ready to land.Sep 29 2015, 2:10 AM

Closed by commit rPa5c417716056: Fix an issue with BuildLogs and web UI during builds (authored by epriestley, committed by epriestley). · Explain WhySep 29 2015, 2:11 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

storage/

build/

HarbormasterBuildLog.php

2 lines

Diff 34266

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Fix an issue with BuildLogs and web UI during buildsClosedPublicActions