Page MenuHomePhabricator
Differential D14184

Simplify value decoding for PHID custom fields
ClosedPublic
Actions

Authored by epriestley on Sep 29 2015, 1:03 AM.
Tags
None
Referenced Files
F13335682: D14184.diff
Wed, Jun 19, 2:52 AM
F13334140: D14184.diff
Tue, Jun 18, 5:20 PM
F13320714: D14184.diff
Fri, Jun 14, 5:54 AM
F13309648: D14184.diff
Mon, Jun 10, 10:26 AM
F13296957: D14184.id34264.diff
Thu, Jun 6, 10:44 PM
F13289668: D14184.id34265.diff
Tue, Jun 4, 1:14 PM
F13289664: D14184.id.diff
Tue, Jun 4, 1:13 PM
F13289662: D14184.diff
Tue, Jun 4, 1:13 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9123: Build Phabricator in Harbormaster (v2)
Commits
Restricted Diffusion Commit
rPefaa8170c353: Simplify value decoding for PHID custom fields
Summary

Ref T9123. The handling in D14183 didn't deal with new field values properly.

Make all this handling more consistent.

Test Plan

Created a new WorkignCopy build plan with some repos.

Diff Detail

Event Timeline

epriestley updated this revision to Diff 34264.Sep 29 2015, 1:03 AM
epriestley retitled this revision from to Simplify value decoding for PHID custom fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9123: Build Phabricator in Harbormaster (v2).
chad accepted this revision.Sep 29 2015, 1:44 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 29 2015, 1:44 AM
Closed by commit rPefaa8170c353: Simplify value decoding for PHID custom fields (authored by epriestley, committed by epriestley). · Explain WhySep 29 2015, 1:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
customfield/
standard/
35 lines

Diff 34264

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

Loading...
Phabricator · Built by Phacility