Page MenuHomePhabricator
Differential D14174

Refine error behavior of `bin/search index`
ClosedPublic
Actions

Authored by epriestley on Sep 27 2015, 5:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 25 2025, 6:31 AM
Unknown Object (File)
May 24 2025, 5:16 PM
Unknown Object (File)
May 9 2025, 9:53 AM
Unknown Object (File)
Apr 24 2025, 2:12 AM
Unknown Object (File)
Apr 17 2025, 8:37 AM
Unknown Object (File)
Apr 16 2025, 10:02 PM
Unknown Object (File)
Mar 23 2025, 3:00 AM
Unknown Object (File)
Mar 22 2025, 11:42 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T5991: `bin/search index` returns 0 on failure
Commits
Restricted Diffusion Commit
rP24845c70b918: Refine error behavior of `bin/search index`
Summary

Fixes T5991. If all requested documents failed to index, consider this a catastrophic failure and exit with an error code.

Test Plan
  • Ran bin/search index --type TASK, observed successful exit despite a small number of un-indexable documents.
  • Ran bin/search index PHID-TASK-xxx for an invalid task, observed exception on exit after complete failure.
  • Ran normal indexing through daemons.

Diff Detail

Repository
rP Phabricator
Branch
xcode2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8069
Build 9170: [Placeholder Plan] Wait for 30 Seconds
Build 9169: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34244.Sep 27 2015, 5:50 PM
epriestley retitled this revision from to Refine error behavior of `bin/search index`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5991: `bin/search index` returns 0 on failure.
epriestley mentioned this in T5991: `bin/search index` returns 0 on failure.Sep 27 2015, 5:54 PM
chad accepted this revision.Sep 27 2015, 6:52 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 27 2015, 6:52 PM
Closed by commit rP24845c70b918: Refine error behavior of `bin/search index` (authored by epriestley, committed by epriestley). · Explain WhySep 27 2015, 8:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
search/
index/
64 lines
management/
15 lines
worker/
12 lines

Diff 34244

View Options

src/applications/search/index/PhabricatorSearchDocumentIndexer.php

Loading...
View Options

src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php

Loading...
View Options

src/applications/search/worker/PhabricatorSearchWorker.php

Loading...
Phabricator · Built by Phacility