Fixes T5991. If all requested documents failed to index, consider this a catastrophic failure and exit with an error code.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T5991: `bin/search index` returns 0 on failure
- Commits
- Restricted Diffusion Commit
rP24845c70b918: Refine error behavior of `bin/search index`
- Ran bin/search index --type TASK, observed successful exit despite a small number of un-indexable documents.
- Ran bin/search index PHID-TASK-xxx for an invalid task, observed exception on exit after complete failure.
- Ran normal indexing through daemons.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- xcode2
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8069 Build 9170: [Placeholder Plan] Wait for 30 Seconds Build 9169: arc lint + arc unit