Page MenuHomePhabricator

Give Drydock leases a resourcePHID instead of a resourceID
ClosedPublic

Authored by epriestley on Sep 24 2015, 3:28 AM.
Tags
None
Referenced Files
F15460287: D14151.diff
Mon, Mar 31, 9:29 PM
F15440335: D14151.id34196.diff
Wed, Mar 26, 12:14 PM
F15432093: D14151.id34193.diff
Mon, Mar 24, 4:02 PM
F15430447: D14151.id.diff
Mon, Mar 24, 7:41 AM
F15428695: D14151.diff
Sun, Mar 23, 9:46 PM
F15428005: D14151.id34193.diff
Sun, Mar 23, 5:37 PM
F15427928: D14151.diff
Sun, Mar 23, 5:14 PM
F15395928: D14151.diff
Sun, Mar 16, 10:47 AM
Subscribers
None

Details

Summary

Ref T9252. Leases currently have a resourceID, but this is a bit nonstandard and generally less flexible than giving them a resourcePHID.

In particular, a resourcePHID is easier to use when rendering interfaces, since you can get handles out of a PHID.

Add a PHID column, copy over all the PHIDs that correspond to existing IDs, then drop the ID column.

Test Plan
  • Browsed web UIs.
  • Inspected database during/after migration.
  • Grepped for resourceID.
  • Allocated a new lease with bin/drydock lease.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give Drydock leases a resourcePHID instead of a resourceID.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
This revision is now accepted and ready to land.Sep 24 2015, 4:44 AM
This revision was automatically updated to reflect the committed changes.