Page MenuHomePhabricator

Give Drydock leases a resourcePHID instead of a resourceID
ClosedPublic

Authored by epriestley on Sep 24 2015, 3:28 AM.

Details

Summary

Ref T9252. Leases currently have a resourceID, but this is a bit nonstandard and generally less flexible than giving them a resourcePHID.

In particular, a resourcePHID is easier to use when rendering interfaces, since you can get handles out of a PHID.

Add a PHID column, copy over all the PHIDs that correspond to existing IDs, then drop the ID column.

Test Plan
  • Browsed web UIs.
  • Inspected database during/after migration.
  • Grepped for resourceID.
  • Allocated a new lease with bin/drydock lease.

Diff Detail

Repository
rP Phabricator
Branch
drydock6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8037
Build 9106: [Placeholder Plan] Wait for 30 Seconds
Build 9105: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Give Drydock leases a resourcePHID instead of a resourceID.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
This revision is now accepted and ready to land.Sep 24 2015, 4:44 AM
This revision was automatically updated to reflect the committed changes.