Page MenuHomePhabricator
Differential D14150

Rename Drydock Lease STATUS_EXPIRED to STATUS_DESTROYED
ClosedPublic
Actions

Authored by epriestley on Sep 24 2015, 2:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 7:28 PM
Unknown Object (File)
Wed, May 1, 1:03 AM
Unknown Object (File)
Mon, Apr 22, 7:20 PM
Unknown Object (File)
Fri, Apr 12, 5:33 PM
Unknown Object (File)
Fri, Apr 12, 5:33 PM
Unknown Object (File)
Wed, Apr 10, 1:37 AM
Unknown Object (File)
Apr 4 2024, 3:30 AM
Unknown Object (File)
Apr 2 2024, 3:50 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9252: Unprototype Drydock (v1)
Commits
Restricted Diffusion Commit
rP309aadc595a1: Rename Drydock Lease STATUS_EXPIRED to STATUS_DESTROYED
Summary

Ref T9252. This is now more consistent (same as the equivalent Resource state) and accurate (leases can end up in this state a bunch of ways, including by expiring).

Test Plan

grep, browsed around web UI.

Diff Detail

Repository
rP Phabricator
Branch
drydock5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8035
Build 9102: [Placeholder Plan] Wait for 30 Seconds
Build 9101: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34191.Sep 24 2015, 2:54 AM
epriestley updated this revision to Diff 34192.
epriestley retitled this revision from to Rename Drydock Lease STATUS_EXPIRED to STATUS_DESTROYED.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9252: Unprototype Drydock (v1).
  • Also prevent releasing destroyed leases. This doesn't hurt anything, but doesn't make sense.
chad accepted this revision.Sep 24 2015, 2:56 AM
chad edited edge metadata.
chad added inline comments.
src/applications/drydock/storage/DrydockLease.php
162

such excite

This revision is now accepted and ready to land.Sep 24 2015, 2:56 AM
Closed by commit rP309aadc595a1: Rename Drydock Lease STATUS_EXPIRED to STATUS_DESTROYED (authored by epriestley, committed by epriestley). · Explain WhySep 24 2015, 3:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
drydock/
constants/
26 lines
controller/
23 lines
storage/
4 lines
worker/
4 lines

Diff 34191

View Options

src/applications/drydock/constants/DrydockLeaseStatus.php

Loading...
View Options

src/applications/drydock/controller/DrydockLeaseViewController.php

Loading...
View Options

src/applications/drydock/storage/DrydockLease.php

Loading...
View Options

src/applications/drydock/worker/DrydockLeaseDestroyWorker.php

Loading...
Phabricator · Built by Phacility