Page MenuHomePhabricator
Differential D14146

Add Application Routes to Phame AppSearch queries
ClosedPublic
Actions

Authored by chad on Sep 23 2015, 6:52 PM.
Tags
None
Referenced Files
F14413736: D14146.id34184.diff
Tue, Dec 24, 2:36 PM
F14413632: D14146.id34185.diff
Tue, Dec 24, 2:30 PM
F14411625: D14146.id34182.diff
Tue, Dec 24, 11:50 AM
Unknown Object (File)
Fri, Dec 20, 3:36 PM
Unknown Object (File)
Fri, Dec 20, 5:11 AM
Unknown Object (File)
Fri, Dec 13, 6:20 AM
Unknown Object (File)
Thu, Dec 5, 9:17 AM
Unknown Object (File)
Wed, Dec 4, 3:18 AM
View All Files
Subscribers
Korvin
Tokens
"Doubloon" token, awarded by epriestley.

Details

Reviewers
epriestley
Maniphest Tasks
T9388: Convert Phame to ApplicationSearch
Commits
Restricted Diffusion Commit
rPbe9cc235b2ed: Add Application Routes to Phame AppSearch queries
Summary

Fixes T9388, lays in basic ApplicationSearch.

Test Plan

Build a dashboard with Posts and Blogs, click on search icon, get sent to correct page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34182.Sep 23 2015, 6:52 PM
chad retitled this revision from to Add Application Routes to Phame AppSearch queries.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9388: Convert Phame to ApplicationSearch.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 23 2015, 6:52 PM
epriestley accepted this revision.Sep 23 2015, 7:10 PM
epriestley edited edge metadata.

This doesn't actually take you to the right page, does it? Like it will always take you to the default query, even if the panel uses a different query?

Still an improvement, I suppose.

This revision is now accepted and ready to land.Sep 23 2015, 7:10 PM
chad added a comment.Sep 23 2015, 7:33 PM

oh, I didn't test alternate queries to the defaults.

chad updated this revision to Diff 34184.Sep 23 2015, 7:45 PM
chad edited edge metadata.
  • Implement ApplicationSearch better
chad requested a review of this revision.Sep 23 2015, 7:46 PM
chad updated this object.
chad edited edge metadata.
epriestley accepted this revision.Sep 23 2015, 7:47 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 23 2015, 7:47 PM
epriestley awarded a token.Sep 23 2015, 7:47 PM
Closed by commit rPbe9cc235b2ed: Add Application Routes to Phame AppSearch queries (authored by chad, committed by chad). · Explain WhySep 23 2015, 7:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
application/
2 lines
controller/
blog/
91 lines
post/
87 lines
query/
1 line

Diff 34185

View Options

src/applications/phame/application/PhabricatorPhameApplication.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogListController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostListController.php

Loading...
View Options

src/applications/phame/query/PhamePostSearchEngine.php

Loading...
Phabricator · Built by Phacility