Page MenuHomePhabricator

Add Application Routes to Phame AppSearch queries
ClosedPublic

Authored by chad on Sep 23 2015, 6:52 PM.

Details

Summary

Fixes T9388, lays in basic ApplicationSearch.

Test Plan

Build a dashboard with Posts and Blogs, click on search icon, get sent to correct page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Add Application Routes to Phame AppSearch queries.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

This doesn't actually take you to the right page, does it? Like it will always take you to the default query, even if the panel uses a different query?

Still an improvement, I suppose.

This revision is now accepted and ready to land.Sep 23 2015, 7:10 PM

oh, I didn't test alternate queries to the defaults.

chad edited edge metadata.
  • Implement ApplicationSearch better
chad requested a review of this revision.Sep 23 2015, 7:46 PM
chad updated this object.
chad edited edge metadata.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 23 2015, 7:47 PM
This revision was automatically updated to reflect the committed changes.