Page MenuHomePhabricator
Differential D14134

Don't allow welcome mail to be sent to users who can't login
ClosedPublic
Actions

Authored by epriestley on Sep 19 2015, 11:48 PM.
Tags
None
Referenced Files
F14357595: D14134.diff
Fri, Dec 20, 5:52 AM
Unknown Object (File)
Wed, Dec 18, 3:05 AM
Unknown Object (File)
Sat, Dec 7, 3:14 AM
Unknown Object (File)
Tue, Dec 3, 4:56 PM
Unknown Object (File)
Mon, Dec 2, 2:33 AM
Unknown Object (File)
Thu, Nov 28, 10:10 PM
Unknown Object (File)
Tue, Nov 26, 1:42 PM
Unknown Object (File)
Sat, Nov 23, 1:02 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9446: "Send Welcome Email" action works for bots and mailing lists
Commits
Restricted Diffusion Commit
rPa0ed843d472a: Don't allow welcome mail to be sent to users who can't login
Summary

Fixes T9446. We allow administrators to send "Welcome" mail to bots and mailing lists.

This is harmless (these links do not function), but confusing.

Instead, disable this option in the UI and explain why it is disabled when it is clicked. Also prevent generation of this mail lower in the stack.

Test Plan
  • Viewed a bot page, saw action disabled, clicked it, got explanation.
  • Viewed a normal user page, saw action enabled, clicked it, sent welcome email.

Diff Detail

Repository
rP Phabricator
Branch
welcome1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8012
Build 9054: [Placeholder Plan] Wait for 30 Seconds
Build 9053: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34139.Sep 19 2015, 11:48 PM
epriestley retitled this revision from to Don't allow welcome mail to be sent to users who can't login.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9446: "Send Welcome Email" action works for bots and mailing lists.
chad accepted this revision.Sep 20 2015, 1:42 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 20 2015, 1:42 AM
Closed by commit rPa0ed843d472a: Don't allow welcome mail to be sent to users who can't login (authored by epriestley, committed by epriestley). · Explain WhySep 20 2015, 11:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
3 lines
25 lines
storage/
7 lines

Diff 34139

View Options

src/applications/people/controller/PhabricatorPeopleProfileController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleWelcomeController.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
Phabricator · Built by Phacility