Page MenuHomePhabricator

Don't allow welcome mail to be sent to users who can't login
ClosedPublic

Authored by epriestley on Sep 19 2015, 11:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 25, 10:41 AM
Unknown Object (File)
Fri, Dec 20, 5:52 AM
Unknown Object (File)
Wed, Dec 18, 3:05 AM
Unknown Object (File)
Sat, Dec 7, 3:14 AM
Unknown Object (File)
Tue, Dec 3, 4:56 PM
Unknown Object (File)
Mon, Dec 2, 2:33 AM
Unknown Object (File)
Nov 28 2024, 10:10 PM
Unknown Object (File)
Nov 26 2024, 1:42 PM
Subscribers
None

Details

Summary

Fixes T9446. We allow administrators to send "Welcome" mail to bots and mailing lists.

This is harmless (these links do not function), but confusing.

Instead, disable this option in the UI and explain why it is disabled when it is clicked. Also prevent generation of this mail lower in the stack.

Test Plan
  • Viewed a bot page, saw action disabled, clicked it, got explanation.
  • Viewed a normal user page, saw action enabled, clicked it, sent welcome email.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't allow welcome mail to be sent to users who can't login.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 20 2015, 1:42 AM
This revision was automatically updated to reflect the committed changes.