Add a box around the pager in Diffusion
ClosedPublic
Actions

Authored by chad on Sep 11 2015, 3:56 PM.

Details

Reviewers

Maniphest Tasks

T9392: Paging UI is missing some padding for Diffusion history view

Commits

Restricted Diffusion Commit
rP875a99524f8b: (stable) Promote 2015 Week 37
rPd199560a6bf9: Add a box around the pager in Diffusion

Summary

Fixes T9392, adds some sweet sweet margin to the pager.

Test Plan

See pager with new padding, test different pages, breakpoints.

Diff Detail

Repository

rP Phabricator

Branch

pager

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7967
Build 8963: [Placeholder Plan] Wait for 30 Seconds
Build 8962: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34075.Sep 11 2015, 3:56 PM

chad retitled this revision from to Add a box around the pager in Diffusion.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9392: Paging UI is missing some padding for Diffusion history view.

Herald added a subscriber: Korvin. · View Herald TranscriptSep 11 2015, 3:56 PM

epriestley accepted this revision.Sep 11 2015, 3:59 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 11 2015, 3:59 PM

Closed by commit rPd199560a6bf9: Add a box around the pager in Diffusion (authored by chad, committed by chad). · Explain WhySep 11 2015, 4:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionHistoryController.php

4 lines

Diff 34075

View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

Add a box around the pager in DiffusionClosedPublicActions