Page MenuHomePhabricator
Differential D14096

Clean up browse/history links in Diffusion
ClosedPublic
Actions

Authored by epriestley on Sep 11 2015, 1:23 AM.
Tags
None
Referenced Files
F13158128: D14096.diff
Sun, May 5, 4:33 PM
Unknown Object (File)
Fri, May 3, 9:19 AM
Unknown Object (File)
Tue, Apr 30, 7:58 AM
Unknown Object (File)
Tue, Apr 30, 7:58 AM
Unknown Object (File)
Tue, Apr 30, 7:51 AM
Unknown Object (File)
Tue, Apr 30, 7:42 AM
Unknown Object (File)
Fri, Apr 26, 8:40 AM
Unknown Object (File)
Thu, Apr 25, 2:57 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9126: diffusion history page should give browse links for each committed version of the file
Commits
Restricted Diffusion Commit
rP4e181a5611fb: Clean up browse/history links in Diffusion
Summary

Fixes T9126. In particular:

  • Add "Browse" links to all history views.
  • Use icons to show "Browse" and "History" links, instead of text.
  • Use FontAwesome.
  • Generally standardize handling of these elements.

This might need a little design attention, but I think it's an improvement overall.

Test Plan
  • Viewed repository history.
  • Viewed branch history.
  • Viewed file history.
  • Viewed table of contents on a commit.
  • Viewed merged changes on a merge commit.
  • Viewed a directory containing an external.
  • Viewed a deleted file.

Screen Shot 2015-09-10 at 6.18.05 PM.png (1×1 px, 194 KB)

Screen Shot 2015-09-10 at 6.17.21 PM.png (1×1 px, 291 KB)

Screen Shot 2015-09-10 at 6.17.44 PM.png (1×1 px, 254 KB)

Screen Shot 2015-09-10 at 6.17.52 PM.png (1×1 px, 321 KB)

Diff Detail

Repository
rP Phabricator
Branch
diffusionbrowse
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7965
Build 8959: [Placeholder Plan] Wait for 30 Seconds
Build 8958: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34069.Sep 11 2015, 1:23 AM
epriestley retitled this revision from to Clean up browse/history links in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9126: diffusion history page should give browse links for each committed version of the file.
Herald edited edge metadata. · View Herald TranscriptSep 11 2015, 1:23 AM
chad accepted this revision.Sep 11 2015, 2:26 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 11 2015, 2:26 AM
Closed by commit rP4e181a5611fb: Clean up browse/history links in Diffusion (authored by epriestley, committed by epriestley). · Explain WhySep 11 2015, 2:28 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T9126: diffusion history page should give browse links for each committed version of the file.Sep 11 2015, 3:23 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
16 lines
src/
applications/
differential/
constants/
15 lines
diffusion/
controller/
20 lines
13 lines
7 lines
view/
35 lines
31 lines
21 lines
115 lines
infrastructure/
diff/
view/
2 lines
webroot/
rsrc/
css/
aphront/
6 lines
application/
diffusion/
33 lines
image/
icon/
fatcow/

Diff 34069

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/constants/DifferentialChangeType.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionBrowseTableView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionEmptyResultView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionView.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php

Loading...
View Options

webroot/rsrc/css/aphront/table-view.css

Loading...
View Options

webroot/rsrc/css/application/diffusion/diffusion-icons.css

Loading...
View Options

webroot/rsrc/image/icon/fatcow/folder.png

Loading...
View Options

webroot/rsrc/image/icon/fatcow/folder_go.png

Loading...
View Options

webroot/rsrc/image/icon/fatcow/page_white_link.png

Loading...
View Options

webroot/rsrc/image/icon/fatcow/page_white_text.png

Loading...
Phabricator · Built by Phacility